Support named lookups for VPC Service IDs#13387
Draft
sodabrew wants to merge 6 commits intocloudflare:mainfrom
Draft
Support named lookups for VPC Service IDs#13387sodabrew wants to merge 6 commits intocloudflare:mainfrom
sodabrew wants to merge 6 commits intocloudflare:mainfrom
Conversation
…service_id VPC service bindings can now specify `service` (a human-readable name) instead of `service_id` (a UUID). Wrangler resolves the name to a service_id via the Cloudflare API at deploy/dev time. The two fields are mutually exclusive. Closes cloudflare#13211
🦋 Changeset detectedLatest commit: 16a107e The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers
|
5 tasks
Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
|
Thanks for the PR. I'm going to move to draft as it shouldn't be reviewed until #13211 has progressed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13211
Today, we have to copy vpc service ids from the Cloudflare Dashboard or use an automation tool like terraform to look up the id and emit it to stdout, and a delete-and-recreate means copying a new ID. This PR proposes a config option to use the friendly name of the vpc service and look up its id at deploy time:
New, can use
service_name:{ "vpc_services": [ { "binding": "API_FOO", "service_name": "api-foo" } ] }Existing, can only use
service_id:{ "vpc_services": [ { "binding": "API_FOO", "service_id": "0199295b-b3ac-7760-8246-bca40877b3e9" } ] }A picture of a cute animal (not mandatory, but encouraged)