Skip to content

Add observability to asset-worker outer entrypoint RPC methods#13474

Draft
courtney-sims wants to merge 4 commits intocloudflare:mainfrom
courtney-sims:csims/wc-4482-2
Draft

Add observability to asset-worker outer entrypoint RPC methods#13474
courtney-sims wants to merge 4 commits intocloudflare:mainfrom
courtney-sims:csims/wc-4482-2

Conversation

@courtney-sims
Copy link
Copy Markdown
Contributor

@courtney-sims courtney-sims commented Apr 15, 2026

Fixes #[insert GH or internal issue link(s)].

Describe your change...

The outer entrypoint's RPC methods (unstable_canFetch, unstable_getByETag, unstable_getByPathname, unstable_exists) previously had no error reporting or tracing. That was only configured for the main fetch. When the router-worker called the RPC methods and they threw, the error was invisible.
This was discovered when deploying the loopback changes to staging. Both flamingo edge tests failed, but nothing appeared in Sentry.

  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because: observability changes only
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: internal changes only

A picture of a cute animal (not mandatory, but encouraged)

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 15, 2026

🦋 Changeset detected

Latest commit: 5ad6338

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Apr 15, 2026

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@13474

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@13474

miniflare

npm i https://pkg.pr.new/miniflare@13474

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@13474

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@13474

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@13474

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@13474

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@13474

wrangler

npm i https://pkg.pr.new/wrangler@13474

commit: 5ad6338

@courtney-sims courtney-sims marked this pull request as ready for review April 15, 2026 14:12
@workers-devprod workers-devprod requested review from a team and petebacondarwin and removed request for a team April 15, 2026 14:12
@workers-devprod
Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • @cloudflare/deploy-config
  • @cloudflare/wrangler
Show detailed file reviewers
  • packages/workers-shared/asset-worker/src/worker.ts: [@cloudflare/deploy-config @cloudflare/wrangler]
  • packages/workers-shared/utils/types.ts: [@cloudflare/deploy-config @cloudflare/wrangler]

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 4 additional findings.

Open in Devin Review

@courtney-sims courtney-sims marked this pull request as draft April 15, 2026 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Untriaged

Development

Successfully merging this pull request may close these issues.

2 participants