Skip to content

chore(miniflare): Add KV ArrayBuffer & stream tests#13561

Merged
petebacondarwin merged 6 commits intomainfrom
NuroDev/local-explorer-kv-tests
Apr 27, 2026
Merged

chore(miniflare): Add KV ArrayBuffer & stream tests#13561
petebacondarwin merged 6 commits intomainfrom
NuroDev/local-explorer-kv-tests

Conversation

@NuroDev
Copy link
Copy Markdown
Member

@NuroDev NuroDev commented Apr 16, 2026

Fixes N/A.

Summary

  • Adds KV & local explorer tests for ArrayBuffer
  • Adds KV & local explorer tests for streams
  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: Internal tooling changes

A picture of a cute animal (not mandatory, but encouraged)

@NuroDev NuroDev self-assigned this Apr 16, 2026
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 16, 2026 •
edited
Loading

⚠️ No Changeset found

Latest commit: 35a5ed1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-project-automation github-project-automation Bot moved this to Untriaged in workers-sdk Apr 16, 2026
@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk Bot commented Apr 16, 2026

Good — Uint8Array.from() creates a new typed array with a tightly-sized ArrayBuffer, so bytes.buffer is safe to use here (no offset/length mismatch issues).

The tests are well-structured, follow existing patterns in the file, use correct APIs, and cover meaningful new scenarios (binary ArrayBuffer and stream round-trips). No logic issues, no security concerns, no backward compatibility problems.

LGTM

github run

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Apr 16, 2026 •
edited
Loading

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@13561

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@13561

miniflare

npm i https://pkg.pr.new/miniflare@13561

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@13561

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@13561

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@13561

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@13561

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@13561

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@13561

wrangler

npm i https://pkg.pr.new/wrangler@13561

commit: 35a5ed1

@NuroDev NuroDev marked this pull request as ready for review April 22, 2026 12:36
@workers-devprod workers-devprod requested review from a team and petebacondarwin and removed request for a team April 22, 2026 12:36
@workers-devprod
Copy link
Copy Markdown
Contributor

workers-devprod commented Apr 22, 2026 •
edited
Loading

Codeowners approval required for this PR:

  • @cloudflare/workers-kv
  • ✅ @cloudflare/wrangler
Show detailed file reviewers
  • packages/miniflare/test/plugins/kv/index.spec.ts: [@cloudflare/workers-kv]

devin-ai-integration[bot]
devin-ai-integration Bot reviewed Apr 22, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

petebacondarwin
petebacondarwin approved these changes Apr 22, 2026
View reviewed changes
Comment thread packages/miniflare/test/plugins/kv/index.spec.ts Outdated
emily-shen
emily-shen reviewed Apr 27, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@emily-shen emily-shen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So what does the UI do if the value is a stream? Or buffer

petebacondarwin
petebacondarwin approved these changes Apr 27, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowners bypass

workers-devprod
workers-devprod approved these changes Apr 27, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@workers-devprod workers-devprod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowners reviews satisfied

@github-project-automation github-project-automation Bot moved this from Untriaged to Approved in workers-sdk Apr 27, 2026
@petebacondarwin petebacondarwin merged commit 41e7b4c into main Apr 27, 2026
58 checks passed
@petebacondarwin petebacondarwin deleted the NuroDev/local-explorer-kv-tests branch April 27, 2026 12:09
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk Apr 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emily-shen emily-shen emily-shen left review comments

@devin-ai-integration devin-ai-integration[bot] devin-ai-integration[bot] left review comments

@petebacondarwin petebacondarwin petebacondarwin approved these changes

@workers-devprod workers-devprod workers-devprod approved these changes

Assignees

@NuroDev NuroDev

Labels

no-changeset-required

Projects

workers-sdk
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@NuroDev @workers-devprod @petebacondarwin @emily-shen