fix(miniflare): return EmailSendResult from send_email binding's send()#13577
Merged
dario-piotrowicz merged 3 commits intocloudflare:mainfrom Apr 20, 2026
Merged
Conversation
The binding's `send()` resolved to `undefined`, diverging from production
(and the public `SendEmail` type), which returns `{ messageId }`. Workers
that inspect the return value now see the same shape locally as deployed.
- EmailMessage path: echo the parsed Message-ID with angle brackets stripped
- MessageBuilder path: synthesize the id in the same `<hex>@example.com`
form already used by the forward() path
🦋 Changeset detectedLatest commit: 2df9c5c The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
workers-devprod
requested review from
a team and
dario-piotrowicz
and removed request for
a team
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers |
Contributor
Author
|
I hit this trying to wire up email sending in workers-rs 👉 cloudflare/workers-rs#975 |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
edevil
approved these changes
Apr 17, 2026
Skye-31
reviewed
Apr 17, 2026
dario-piotrowicz
approved these changes
Apr 20, 2026
Member
dario-piotrowicz
left a comment
dario-piotrowicz
left a comment
There was a problem hiding this comment.
Looks good to me, thanks @connyay 🙏
workers-devprod
approved these changes
Apr 20, 2026
Contributor
workers-devprod
left a comment
workers-devprod
left a comment
There was a problem hiding this comment.
Codeowners reviews satisfied
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The binding's
send()resolved toundefined, diverging from production (and the publicSendEmailtype), which returns{ messageId }. Workers that inspect the return value now see the same shape locally as deployed.<hex>@example.comform already used by the forward() pathA picture of a cute animal (not mandatory, but encouraged)
https://www.youtube.com/watch?v=FykoipfMyNQ