feat(vite-plugin): allow env override for wrangler config path#13587
Conversation
🦋 Changeset detectedLatest commit: 2b89127 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codeowners approval required for this PR:
Show detailed file reviewers |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
|
Just to be clear, are you suggesting that SST would write its Wrangler config file path into the |
petebacondarwin
left a comment
There was a problem hiding this comment.
LGTM but getting a second opinion from the rest of the Vite plugin team
that's right, that way users wouldn't need to specify a |
petebacondarwin
left a comment
There was a problem hiding this comment.
Checked with @jamesopstad - we are good to land this
workers-devprod
left a comment
There was a problem hiding this comment.
Codeowners reviews satisfied
Frameworks like SST might autogenerate wrangler files for deployments.
Currently this requires users to do the following:
Source from the Astro component.
To make the integration easier, this pull request adds the ability to specify the
configPathvia theCLOUDFLARE_VITE_WRANGLER_CONFIG_PATHenvironment variable.This way, frameworks built on top of Cloudflare can automatically configure wrangler without users needing to change anything.
A picture of a cute animal (not mandatory, but encouraged)