Skip to content

[wrangler] Fix broken runInTempDir import in unstable-get-miniflare-worker-options test#13972

Merged
petebacondarwin merged 1 commit into
mainfrom
pbd/fix-main
May 19, 2026
Merged

[wrangler] Fix broken runInTempDir import in unstable-get-miniflare-worker-options test#13972
petebacondarwin merged 1 commit into
mainfrom
pbd/fix-main

Conversation

@petebacondarwin

@petebacondarwin petebacondarwin commented May 19, 2026

Copy link
Copy Markdown
Contributor

#13919 added packages/wrangler/src/__tests__/unstable-get-miniflare-worker-options.test.ts with import { runInTempDir } from "./helpers/run-in-tmp". After it was rebased, #13954's helper refactor (12e491e6e) had already deleted that file and moved runInTempDir to @cloudflare/workers-utils/test-helpers, leaving an import on main that points at a non-existent module.

This PR updates the import to use @cloudflare/workers-utils/test-helpers like the rest of the wrangler test suite.


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because: this PR is the fix to the broken test import; running the affected test file under vitest verifies it.
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: test-only fix, no user-facing behaviour change.

Open in Devin Review

@petebacondarwin petebacondarwin added the ci:no-changeset-required Skip pull request checks for a valid changeset label May 19, 2026
@changeset-bot

changeset-bot Bot commented May 19, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 367c1df

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-project-automation github-project-automation Bot moved this to Untriaged in workers-sdk May 19, 2026
@workers-devprod workers-devprod requested review from a team and penalosa and removed request for a team May 19, 2026 14:52
@workers-devprod

workers-devprod commented May 19, 2026

Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler
Show detailed file reviewers

@ask-bonk

ask-bonk Bot commented May 19, 2026

Copy link
Copy Markdown
Contributor

LGTM

github run

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

@workers-devprod workers-devprod left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowners reviews satisfied

@github-project-automation github-project-automation Bot moved this from Untriaged to Approved in workers-sdk May 19, 2026
@petebacondarwin petebacondarwin enabled auto-merge (squash) May 19, 2026 14:56
@petebacondarwin petebacondarwin merged commit 1f4455a into main May 19, 2026
60 of 66 checks passed
@petebacondarwin petebacondarwin deleted the pbd/fix-main branch May 19, 2026 15:04
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk May 19, 2026
penalosa pushed a commit that referenced this pull request May 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:no-changeset-required Skip pull request checks for a valid changeset

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants