[miniflare] Point HTTPS-CA test at a stable URL#13973
Merged
Merged
Conversation
`packages/miniflare/test/index.spec.ts` had a test that fetched `https://workers.cloudflare.com/cf.json` from inside a worker and asserted `res.ok === true` to verify that workerd trusts public CAs. That URL now permanently 301s to `https://www.cloudflare.com/cf.json` which returns 404 `not found :(`. Following the redirect produces a non-OK response and the test fails on every CI run regardless of the change under test, blocking all PRs touching anything in the packages-and-tools matrix. Switch the test to `https://example.com/` — the IANA-maintained stable test endpoint — which serves a 200 over HTTPS with a public CA chain and so still exercises the original behaviour the test was written to verify.
|
workers-devprod
requested review from
a team and
james-elicx
and removed request for
a team
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers |
Contributor
|
LGTM |
5 tasks
Contributor
|
✅ All changesets look good |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
james-elicx
approved these changes
May 19, 2026
workers-devprod
approved these changes
May 19, 2026
workers-devprod
left a comment
workers-devprod
left a comment
Contributor
There was a problem hiding this comment.
Codeowners reviews satisfied
petebacondarwin
added
the
ci:no-changeset-required
ascorbic
approved these changes
May 19, 2026
ascorbic
left a comment
ascorbic
left a comment
Contributor
There was a problem hiding this comment.
I think the missing cf.json is a bigger issue, but shouldn't block this
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
penalosa
pushed a commit
that referenced
this pull request
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No tracked issue; this fixes a CI-blocking regression on `main`.
What
The `Miniflare: HTTPS fetches using browser CA certificates` test at `packages/miniflare/test/index.spec.ts:1566` was fetching `https://workers.cloudflare.com/cf.json\` from inside a worker and asserting `res.ok === true` to verify that workerd trusts public CAs.
That URL now permanently 301s to `https://www.cloudflare.com/cf.json\` which returns 404 with the body `not found :(`:
fetch()follows the redirect by default, so the worker sees the 404. `res.ok` is false. The test fails on every CI run regardless of the change under test, blocking all PRs touching anything in the packages-and-tools matrix (e.g. #13971).How
Switch the test to fetch `https://example.com/\` — the IANA-maintained stable test endpoint — which serves 200 OK over HTTPS with a public CA chain. The test still exercises the original behaviour it was written to verify (workerd trusting the system/public CA store) without depending on a Cloudflare-controlled URL whose lifecycle is outside this repo.
I considered keeping a Cloudflare-owned URL (e.g. `https://www.cloudflare.com/\` returns 200) but `example.com` is purpose-built for this kind of test and won't quietly disappear.
Test plan
Note on `packages/miniflare/src/cf.ts`
The same `https://workers.cloudflare.com/cf.json\` URL is also hard-coded as `defaultCfFetchEndpoint` in `packages/miniflare/src/cf.ts:49`. That code already falls back to `fallbackCf` on fetch failure so it's degraded but not broken at runtime — and updating it is out of scope for this minimal CI-unblocker. Worth a follow-up to point it at the correct URL (or strip it entirely if cf.json is no longer published).