-
Notifications
You must be signed in to change notification settings - Fork 1.4k
feat(c3): scaffold Next.js apps with vinext instead of OpenNext #14896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
scottbuscemi
wants to merge
3
commits into
cloudflare:main
Choose a base branch
from
scottbuscemi:c3-next-use-vinext
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| --- | ||
| "create-cloudflare": minor | ||
| --- | ||
|
|
||
| feat: make vinext the default Next.js scaffold, keep OpenNext as a variant | ||
|
|
||
| `create-cloudflare --framework=next` now prompts for a Next.js adapter: | ||
|
|
||
| - **vinext** (default / recommended) — scaffolds via `create-vinext-app` (`vinext dev` / `vinext build` / `vinext-cloudflare deploy`) | ||
| - **opennext** — keeps the previous OpenNext remote template for projects that need standard `next build` output or a capability vinext does not support yet | ||
|
|
||
| Non-interactive usage: | ||
|
|
||
| ```sh | ||
| npm create cloudflare@latest my-app -- --framework=next --variant=vinext | ||
| npm create cloudflare@latest my-app -- --framework=next --variant=opennext | ||
| ``` | ||
|
|
||
| `-y` / `--accept-defaults` selects vinext. This aligns C3 with the recommended Next.js-on-Workers path in the Cloudflare docs while preserving an opt-in OpenNext path. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30 changes: 4 additions & 26 deletions
30
packages/create-cloudflare/templates/next/experimental_c3.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,26 +1,4 @@ | ||
| import { runFrameworkGenerator } from "frameworks/index"; | ||
| import type { TemplateConfig } from "../../src/templates"; | ||
| import type { C3Context } from "types"; | ||
|
|
||
| const generate = async (ctx: C3Context) => { | ||
| await runFrameworkGenerator(ctx, [ | ||
| ctx.project.name, | ||
| "--skip-install", | ||
| ]); | ||
| }; | ||
|
|
||
| const envInterfaceName = "CloudflareEnv"; | ||
| const typesPath = "./cloudflare-env.d.ts"; | ||
| export default { | ||
| configVersion: 1, | ||
| id: "next", | ||
| frameworkCli: "create-next-app", | ||
| platform: "workers", | ||
| displayName: "Next.js", | ||
| generate, | ||
| devScript: "dev", | ||
| previewScript: "preview", | ||
| deployScript: "deploy", | ||
| typesPath, | ||
| envInterfaceName, | ||
| } as TemplateConfig; | ||
| // Experimental Next.js path shares the stable vinext/OpenNext variant flow. | ||
| // create-vinext-app (default) and the OpenNext remote template are both already | ||
| // Workers-ready, so no separate experimental generator is needed. | ||
| export { default } from "./c3"; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.