[vitest-pool-workers] Preserve deprecated Miniflare cache option - #14913
Closed
edmundhung wants to merge 6 commits into
Closed
[vitest-pool-workers] Preserve deprecated Miniflare cache option#14913edmundhung wants to merge 6 commits into
edmundhung wants to merge 6 commits into
Conversation
🦋 Changeset detectedLatest commit: b231e27 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
✅ All changesets look good |
Contributor
|
No other references. The implementation is coherent and correct. Let me summarize my findings: The core logic is correct:
Minor observations (not bugs, not actionable):
None of these rise to the level of a logic bug, security issue, backward-compat violation, or incorrect API behavior. The one behavioral edge — There are no actionable issues. LGTM |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
@cloudflare/autoconfig
@cloudflare/config
create-cloudflare
@cloudflare/deploy-helpers
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-auth
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
emily-shen
force-pushed
the
miniflare-v5
branch
2 times, most recently
from
July 29, 2026 16:25
c91813f to
1f75897
Compare
emily-shen
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserves the deprecated Miniflare cache worker option in @cloudflare/vitest-pool-workers while Miniflare v5 renames it to cacheAPI.
The pool normalizes worker options before Miniflare schema parsing, for both the test runner and auxiliary workers. cacheAPI takes precedence when both names are provided. The legacy cache field remains typed with a deprecation annotation so existing configurations continue to compile.
A picture of a cute animal (not mandatory, but encouraged)