Skip to content

[create-cloudflare] Disable pnpm self-provisioning in framework E2E - #14955

Merged
edmundhung merged 4 commits into
mainfrom
edmundhung/diagnose-c3-nuxt-pnpm-race
Aug 3, 2026
Merged

[create-cloudflare] Disable pnpm self-provisioning in framework E2E#14955
edmundhung merged 4 commits into
mainfrom
edmundhung/diagnose-c3-nuxt-pnpm-race

Conversation

@edmundhung

@edmundhung edmundhung commented Jul 31, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Framework generators may write a pnpm version to their generated packageManager field that differs from the C3 E2E matrix version. pnpm then downloads and runs that version. When concurrent framework tests provision it through the same pnpm tool store, provisioning can recurse until Node fails with ERANGE: uv_cwd.

Disable automatic package-manager version provisioning only for the framework E2E run. This keeps concurrent framework coverage while avoiding shared pnpm tool-store mutation. Other C3 E2E jobs retain their existing behavior.

This addresses the failure reproduced consistently across attempts 2–6 of #14924.

  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: this only changes test-runner configuration and has no user-facing behavior.

A picture of a cute animal (not mandatory, but encouraged)

@changeset-bot

changeset-bot Bot commented Jul 31, 2026 •
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: f6edef0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-project-automation github-project-automation Bot moved this to Untriaged in workers-sdk Jul 31, 2026
@edmundhung edmundhung added run-c3-frameworks-tests Run all the C3 frameworks tests on this PR ci:no-changeset-required Skip pull request checks for a valid changeset labels Jul 31, 2026
@ask-bonk

ask-bonk Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

The repo is on Vitest 4.1.0. As confirmed by the docs, test.sequential (and .concurrent) are deprecated in Vitest 4 in favor of concurrent: false. However, deprecation is not a functional bug — it still works. This is a temporary diagnostic PR that will be removed once the race is confirmed, so flagging a deprecation for throwaway code would be a nitpick.

Let me assess whether there's a real functional concern. The stated goal is to check if concurrent pnpm-version provisioning causes the Nuxt failures. The change makes only Nuxt tests sequential. That is exactly what the code does. No logic bug.

I've evaluated:

  • frameworkConfig.id === "nuxt" correctly matches all 4 Nuxt variants — correct.
  • .sequential chaining on test.runIf(...) is valid — correct.
  • Semantics achieve the diagnostic goal — correct.
  • No security, backward-compat, or API-behavior issues.
  • Deprecation of .sequential is a nitpick for throwaway diagnostic code, and not a functional issue.

No actionable issues.

LGTM

github run

@pkg-pr-new

pkg-pr-new Bot commented Jul 31, 2026 •
edited
Loading

Copy link
Copy Markdown
@cloudflare/autoconfig

npm i https://pkg.pr.new/@cloudflare/autoconfig@14955

@cloudflare/build-output-utils

npm i https://pkg.pr.new/@cloudflare/build-output-utils@14955

@cloudflare/config

npm i https://pkg.pr.new/@cloudflare/config@14955

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@14955

@cloudflare/deploy-helpers

npm i https://pkg.pr.new/@cloudflare/deploy-helpers@14955

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@14955

miniflare

npm i https://pkg.pr.new/miniflare@14955

@cloudflare/pages-functions

npm i https://pkg.pr.new/@cloudflare/pages-functions@14955

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@14955

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@14955

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@14955

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@14955

@cloudflare/workers-auth

npm i https://pkg.pr.new/@cloudflare/workers-auth@14955

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@14955

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@14955

wrangler

npm i https://pkg.pr.new/wrangler@14955

commit: f6edef0

@edmundhung edmundhung changed the title [create-cloudflare] Diagnose concurrent Nuxt framework failures [create-cloudflare] Serialize Nuxt framework E2E tests Jul 31, 2026
@edmundhung edmundhung changed the title [create-cloudflare] Serialize Nuxt framework E2E tests [create-cloudflare] Prevent pnpm provisioning races in framework E2E Jul 31, 2026
@edmundhung edmundhung changed the title [create-cloudflare] Prevent pnpm provisioning races in framework E2E [create-cloudflare] Disable pnpm self-provisioning in framework E2E Jul 31, 2026
@edmundhung
edmundhung marked this pull request as ready for review July 31, 2026 16:35
@workers-devprod
workers-devprod requested review from a team and NuroDev and removed request for a team July 31, 2026 16:35
@workers-devprod

workers-devprod commented Jul 31, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler
Show detailed file reviewers

devin-ai-integration[bot]

This comment was marked as resolved.

Sign in to view

workers-devprod
workers-devprod approved these changes Aug 3, 2026
View reviewed changes

@workers-devprod workers-devprod left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowners reviews satisfied

@github-project-automation github-project-automation Bot moved this from Untriaged to Approved in workers-sdk Aug 3, 2026
@edmundhung
edmundhung merged commit 3fc24e1 into main Aug 3, 2026
63 checks passed
@edmundhung
edmundhung deleted the edmundhung/diagnose-c3-nuxt-pnpm-race branch August 3, 2026 17:07
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk Aug 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devin-ai-integration devin-ai-integration[bot] devin-ai-integration[bot] left review comments
@NuroDev NuroDev NuroDev approved these changes
@workers-devprod workers-devprod workers-devprod approved these changes

Assignees

No one assigned

Labels

ci:no-changeset-required Skip pull request checks for a valid changeset run-c3-frameworks-tests Run all the C3 frameworks tests on this PR

Projects

workers-sdk
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@edmundhung @workers-devprod @NuroDev