Skip to content

Commit bc2469b

Browse files
remove unneeded rules, add config for scripts (#253)
Signed-off-by: Kangrui Johann Ye <kangrui.ye@cloudflight.io>
1 parent ebc7e06 commit bc2469b

33 files changed

Lines changed: 66 additions & 1061 deletions

eslint.config.mjs

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -11,23 +11,14 @@ export default tseslint.config(
1111
includeIgnoreFile(gitignorePath),
1212
...cloudflightTypescriptConfig({
1313
rootDirectory: import.meta.dirname,
14-
tsConfigFiles: ['./packages/*/tsconfig.json', './packages/*/tsconfig.spec.json'],
14+
tsConfigFiles: ['./packages/*/tsconfig.json', './packages/*/tsconfig.spec.json', './tsconfig.eslint.json'],
1515
}),
1616
{
1717
// these files are temporarily disabled for linting
1818
// until we are done with migrating everything to v9
1919
ignores: [
2020
'packages/eslint-plugin-angular/src/configs/format-template.ts',
21-
'packages/eslint-plugin-typescript/src/configs/index.ts',
22-
'packages/eslint-plugin-typescript/src/configs/json.ts',
23-
'packages/eslint-plugin-typescript/src/configs/package.ts',
24-
'packages/eslint-plugin-typescript/src/rules/package/*',
25-
'packages/eslint-plugin-typescript/src/rules/ts-config/*',
2621
'packages/eslint-plugin-typescript/src/rules/typescript/*.spec.ts',
27-
'scripts/*',
28-
'eslint.config.mjs',
29-
'eslint.format.mjs',
30-
'jest.config*.ts',
3122
],
3223
},
3324
{

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
"lint": "eslint . && eslint -c eslint.format.mjs .",
2020
"test": "yarn workspaces foreach -pA run test-package",
2121
"postinstall": "husky",
22-
"publish-workspaces": "node ./scripts/prepare.js && yarn workspaces foreach -A --no-private npm publish"
22+
"publish-workspaces": "node ./scripts/prepare.mjs && yarn workspaces foreach -A --no-private npm publish"
2323
},
2424
"keywords": [
2525
"eslint",

packages/eslint-plugin-typescript/src/configs/json.ts

Lines changed: 0 additions & 39 deletions
This file was deleted.

packages/eslint-plugin-typescript/src/configs/package.ts

Lines changed: 0 additions & 13 deletions
This file was deleted.

packages/eslint-plugin-typescript/src/rules/index.ts

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -4,24 +4,6 @@ import {NoMomentJsRule, NoMomentJsRuleName} from './typescript/no-moment-js';
44
import {NoOnEventAssign, NoOnEventAssignName} from './typescript/no-on-event-assign';
55

66
const rules: Record<string, TSESLint.RuleModule<string, readonly unknown[]>> = {
7-
// todo: eslint-plugin-json-es is not compatible with eslint v9 as of writing
8-
// and will be migrated later
9-
// [PackageForcePrivateRuleName]: PackageForcePrivateRule,
10-
// [PackageForceAbsoluteVersionDependenciesRuleName]: PackageForceAbsoluteVersionDependenciesRule,
11-
// [TscAllowUnreachableCodeRuleName]: TscAllowUnreachableCodeRule,
12-
// [TscAllowUnusedLabelsRuleName]: TscAllowUnusedLabelsRule,
13-
// [TscEsModuleInteropRuleName]: TscEsModuleInteropRule,
14-
// [TscForceConsistentCasingInFileNamesRuleName]: TscForceConsistentCasingInFileNamesRule,
15-
// [TscImportHelpersRuleName]: TscImportHelpersRule,
16-
// [TscImportsNotUsedAsValuesRuleName]: TscImportsNotUsedAsValuesRule,
17-
// [TscIsolatedModulesRuleName]: TscIsolatedModulesRule,
18-
// [TscNoFallThroughCasesInSwitchRuleName]: TscNoFallThroughCasesInSwitchRule,
19-
// [TscNoImplicitOverrideRuleName]: TscNoImplicitOverrideRule,
20-
// [TscNoImplicitReturnsRuleName]: TscNoImplicitReturnsRule,
21-
// [TscNoPropertyAccessFromIndexSignatureRuleName]: TscNoPropertyAccessFromIndexSignatureRule,
22-
// [TscNoUncheckedIndexedAccessRuleName]: TscNoUncheckedIndexedAccessRule,
23-
// [TscStrictRuleName]: TscStrictRule,
24-
// [TscUseDefineForClassFieldsRuleName]: TscUseDefineForClassFieldsRule,
257
[NoMomentJsRuleName]: NoMomentJsRule,
268
[NoOnEventAssignName]: NoOnEventAssign,
279
};

packages/eslint-plugin-typescript/src/rules/package/package-force-absolute-version-dependencies.rule.spec.ts

Lines changed: 0 additions & 125 deletions
This file was deleted.

packages/eslint-plugin-typescript/src/rules/package/package-force-absolute-version-dependencies.rule.ts

Lines changed: 0 additions & 74 deletions
This file was deleted.

packages/eslint-plugin-typescript/src/rules/package/package-force-private.rule.spec.ts

Lines changed: 0 additions & 48 deletions
This file was deleted.

0 commit comments

Comments
 (0)