PR: mzd Aramco to Aramco#141
Closed
spaceone-gcp wants to merge 347 commits into
Closed
Conversation
refactor(cloud run, cloud build): seperate by version
- Update Datastore metrics format (count.yaml, database_type.yaml, index_count.yaml, namespace_count.yaml) - Update Firestore metrics format (database_count.yaml, document_count.yaml) - Add new StorageTransfer metrics format (count.yml files) - Remove old namespace.yaml files for Datastore and Firestore - Update version numbers for Datastore namespace files
- Remove old namespace.yaml files for Datastore and Firestore - Remove old count.yaml files for StorageTransfer services - Remove old namespace.yaml files for StorageTransfer services - These files have been replaced with new format files
chore(cloud run, cloud build): change log level and icon path
- Kubernetes Engine을 Cluster와 NodePool로 분리 - NodePool 전용 모델, 매니저, 위젯 생성 - BaseDynamicWidget 'type' 파라미터 에러 수정 - App Engine과 Kubernetes Engine namespace.yaml 추가 - 아이콘 경로 표준화 (Google_App_Engine.svg → App_Engine.svg) - 필드 중복 제거 및 날짜 데이터 처리 개선 - "Project ID" → "Project" 필드명 통일 - convert_datetime 함수로 날짜 형식 일관성 확보
- Override name field in NodePool model to ensure serialization even when None/empty - Add fallback logic in manager to handle missing node_pool_name values - Comprehensive testing confirms Basic Information Name field will display correctly - Fixes issue where name field appeared as null in UI responses
- Add missing 'name' field at resource level in NodePoolResource creation - Restore data field definition in NodePoolResource for consistency with GKEClusterResource - Fix root cause: NodePool was missing resource.name while Cluster had it properly set - Both cluster and nodepool now have identical structure: resource.name and data.name - Resolves Basic Information Name field showing null in UI
- Remove explicit data field definition from NodePoolResource - Use inherited PolyModelType from CloudServiceResource instead of ModelType - Eliminates potential data field duplication in raw responses - Comprehensive testing confirms no nested data objects - Both resource.name and data.name fields work correctly - UI Name field will display properly without duplication
- Change NodePool from BaseResource to Model to avoid CloudServiceResource field inheritance - Add google_cloud_monitoring and google_cloud_logging fields explicitly to NodePool - Change NodePool model creation from strict=False to strict=True to prevent extra fields - Add debug logging to track original node_group data structure - Eliminates duplicate fields: provider, account, cloud_service_group, cloud_service_type, reference, region_code, ip_addresses, data - Comprehensive testing confirms clean data structure without nested duplications
- Add DateTimeType to imports in cloud_service.py - Add create_time, update_time, api_version fields to NodePool model - Resolves Rogue field error when using strict=True validation - All manager-provided fields now properly defined in model schema - Maintains data consistency without unnecessary field inclusion
…a object
- Add data = ModelType(NodePool) to NodePoolResource class
- Matches App Engine Service pattern with explicit ModelType definition
- Prevents CloudServiceResource's PolyModelType default lambda: {} from creating empty data object
- Eliminates nested empty data: {} in NodePool responses
- Comprehensive testing confirms clean data structure without duplications
- Consistent with other service resource implementations
BREAKING CHANGE: Complete restructuring to follow SpaceONE standard pattern - Move NodePool data model from cloud_service.py to data.py (matches App Engine pattern) - NodePool now inherits from BaseResource in data.py like all other services - Remove all model classes from cloud_service.py (NodeConfig, AutoScaling, etc.) - Add proper import: from .data import NodePool in cloud_service.py - Maintain explicit data = ModelType(NodePool) in NodePoolResource - Fix circular import issue in data.py - Clean up unnecessary imports and eliminate code duplication - Follow standard SpaceONE architecture pattern used by: * App Engine Service (data.py: AppEngineService(BaseResource)) * Storage Transfer (data.py: TransferJob(BaseResource)) * Firestore Database (data.py: Database(BaseResource)) * Datastore (data.py: DatastoreIndexData(BaseResource)) Testing confirms: - ✅ Perfect standard pattern compliance - ✅ No nested data objects - ✅ No CloudService field duplication - ✅ Consistent with all other SpaceONE services
- Change import from cloud_service.py to data.py in node_pool_v1_manager.py - Manager now imports NodePool from .data module (standard SpaceONE pattern) - Keep NodePoolResource and NodePoolResponse import from cloud_service.py - Maintain strict=True for proper validation - Ensures consistent import pattern across all components: * Manager imports data models from data.py * UI/Resource components import from cloud_service.py - Testing confirms all imports work correctly and no circular dependencies
|
✅ Why it is requiredThe Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO. Contributors sign-off that they adhere to these requirements by adding a Git even has a |
1 similar comment
|
✅ Why it is requiredThe Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO. Contributors sign-off that they adhere to these requirements by adding a Git even has a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category
Description
Known issue