fixing review commnets, adding tests

Author: Prasad, Hari

out

@@ -24,8 +24,8 @@ if [[ ${disable} == "true" ]]; then
     exit 0
 fi
 
-webhook_url="$(  jq --raw-output '.source.url // "https://slack.com/api/chat.postMessage"' < "${payload}")"
-oauth_token="$(  jq --raw-output '.source.token' < "${payload}")"
+webhook_url="$(  jq --raw-output '.source.url // "https://slack.com/api/chat.postMessage"' <<< "${payload}")"
+oauth_token="$(  jq --raw-output '.source.token' <<< "${payload}")"
 allow_insecure=$(jq --raw-output '.source.insecure // "false"' <<< "${payload}")
 raw_ca_certs=$(  jq              '.source.ca_certs // []'      <<< "${payload}")
 
@@ -176,9 +176,9 @@ EOF
         elif [[ "${silent}" == "true" ]]; then
             echo "INFO: using silent output"
             if [[ -n ${oauth_token} ]]; then
-                curl -s -X POST -H 'Content-type: application/json' \
-                     -H "Authorization: Bearer ${oauth_token}" \
-                     -T /tmp/compact_body.json ${CURL_OPTION} "${webhook_url}"
+                curl --silent -X POST --header 'Content-type: application/json' \
+                     --header "Authorization: Bearer ${oauth_token}" \
+                     --data-raw "${compact_body}" ${CURL_OPTIONS[@]} "${webhook_url}"
             else
                 curl --silent --fail --show-error --location "${CURL_OPTIONS[@]}" \
                     --request "POST" --url "${webhook_url}" \
@@ -190,10 +190,10 @@ EOF
                 sed -Ee 's,https?://[^/]*(/[^?&#]*).*,\1,' <<< "${webhook_url}"
             )
             if [[ -n ${oauth_token} ]]; then
-                curl -v -X POST -H 'Content-type: application/json' \
-                     -H "Authorization: Bearer ${oauth_token}" \
-                     -T /tmp/compact_body.json \
-                     ${CURL_OPTION} "${webhook_url}" 2>&1 | sed -e "s#${url_path}#***WEBHOOK URL REDACTED***#g"
+                curl -v -X POST --header 'Content-type: application/json' \
+                     --header "Authorization: Bearer ${oauth_token}" \
+                     --data-raw "${compact_body}" \
+                     ${CURL_OPTIONS[@]} "${webhook_url}" 2>&1 | sed -e "s#${url_path}#***OAUTH TOKEN REDACTED***#g"
             else
                 curl --verbose --silent --fail --show-error --location "${CURL_OPTIONS[@]}" \
                         --request "POST" --url "${webhook_url}" \
@@ -203,10 +203,10 @@ EOF
             curl_errors=$(( ${curl_errors} + ${PIPESTATUS[0]} ))
         else
             if [[ -n ${oauth_token} ]]; then
-                curl -v -X POST -H 'Content-type: application/json' \
-                     -H "Authorization: Bearer ${oauth_token}" \
-                     -T /tmp/compact_body.json \
-                     ${CURL_OPTION} "${webhook_url}" | sed -e "s#${url_path}#***WEBHOOK URL REDACTED***#g"
+                curl -v -X POST --header 'Content-type: application/json' \
+                     --header "Authorization: Bearer ${oauth_token}" \
+                     --data-raw "${compact_body}" \
+                     ${CURL_OPTIONS[@]} "${webhook_url}" | sed -e "s#${url_path}#***OAUTH TOKEN REDACTED***#g"
             else
                 curl --verbose --silent --fail --show-error --location "${CURL_OPTIONS[@]}" \
                         --request "POST" --url "${webhook_url}" \

test/all.sh

@@ -254,4 +254,18 @@ test env_file | jq -e "
   .body.attachments[1].text == \"<something> - ./path/to/*.jar\" and
   ( .body.attachments | length == 2 )"
 
+oauth_token_test() {
+  payload='{ "source": { "token": "test-oauth-token" }, "params": { "text": "Test message" } }'
+  result=$(echo "$payload" | ${cmd})
+  expected='{"version":{"timestamp":"$(date +%s)"}}'
+  if [[ "$result" == *"version"* ]]; then
+    echo "OAuth token test passed"
+  else
+    echo "OAuth token test failed: expected $expected but got $result"
+  fi
+}
+
+# Call the oauth_token_test function
+oauth_token_test
+
 echo -e '\e[32;1m'"All tests passed!"'\e[0m'