Skip to content

feat: adding oauth token support#104

Open
hriprsd wants to merge 3 commits intocloudfoundry-community:developfrom
hriprsd:master
Open

feat: adding oauth token support#104
hriprsd wants to merge 3 commits intocloudfoundry-community:developfrom
hriprsd:master

Conversation

@hriprsd
Copy link
Copy Markdown

@hriprsd hriprsd commented Mar 12, 2025

No description provided.

@hriprsd hriprsd changed the base branch from master to develop March 12, 2025 04:29
@hriprsd
Copy link
Copy Markdown
Author

hriprsd commented Mar 12, 2025

I have added support for oauth_tokens, kindly review. Thanks!

Copy link
Copy Markdown
Contributor

@bgandon bgandon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

However, this is a fairly untested piece of code, as many errors will prevent it from working at all.

Please fix your code, test it, add automated test cases to the test suite, have the automated tests pass, and we'll be glad to accept it.

Comment thread out Outdated
Comment thread out Outdated
Comment thread out Outdated
Comment thread out Outdated
@hriprsd
Copy link
Copy Markdown
Author

hriprsd commented Mar 19, 2025

@bgandon Thanks for the detailed review. I have fixed the review comments, added tests and made sure everything passes.

@hriprsd
Copy link
Copy Markdown
Author

hriprsd commented Mar 24, 2025

Could someone please review - thanks in advance! 😸

@hriprsd
Copy link
Copy Markdown
Author

hriprsd commented Apr 2, 2025

Any updates on this please?

@hriprsd
Copy link
Copy Markdown
Author

hriprsd commented Apr 8, 2025

@bgandon Any updates on this please?

@hriprsd
Copy link
Copy Markdown
Author

hriprsd commented Apr 29, 2025

Can someone please review this? Its been a while, just checking in, Thanks in advance!

@hriprsd
Copy link
Copy Markdown
Author

hriprsd commented Jul 3, 2025

@bgandon Any updates on this please? its been a while - anything required from my side, please do let me know! Thanks 😺

@hriprsd
Copy link
Copy Markdown
Author

hriprsd commented Jul 31, 2025

Any updates on this please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants