fix: generate other-user password locally and create CF user at deploy time

other_user_password was previously stored in credhub via credhub generate,
which has been removed. Now generated with openssl rand and the CF user is
created during build-extension-file (requires admin, then restores
deployment login).

Author: bonzofenix

scripts/extension-file.tpl.yaml

@@ -87,8 +87,6 @@ modules:
           "use_existing_user": ${USE_EXISTING_USER},
           "existing_user": "${EXISTING_USER}",
           "existing_user_password": "${EXISTING_USER_PASSWORD}",
-          "other_existing_user": "${AUTOSCALER_OTHER_USER}",
-          "other_existing_user_password": "${AUTOSCALER_OTHER_USER_PASSWORD}",
           "keep_user_at_suite_end": ${KEEP_USER_AT_SUITE_END},
           "add_existing_user_to_existing_space": ${ADD_EXISTING_USER_TO_EXISTING_SPACE},
           "use_existing_organization": ${USE_EXISTING_ORGANIZATION},

scripts/vars.source.sh

@@ -76,11 +76,6 @@ debug "AUTOSCALER_ORG_MANAGER_USER: ${AUTOSCALER_ORG_MANAGER_USER}"
 log "set up vars: AUTOSCALER_ORG_MANAGER_USER=${AUTOSCALER_ORG_MANAGER_USER}"
 autoscaler_org_manager_user="${AUTOSCALER_ORG_MANAGER_USER}"
 
-export AUTOSCALER_OTHER_USER="${AUTOSCALER_OTHER_USER:-other-user}"
-debug "AUTOSCALER_OTHER_USER: ${AUTOSCALER_OTHER_USER}"
-log "set up vars: AUTOSCALER_OTHER_USER=${AUTOSCALER_OTHER_USER}"
-autoscaler_other_user="${AUTOSCALER_OTHER_USER}"
-
 export SYSTEM_DOMAIN="${SYSTEM_DOMAIN:-"autoscaler.app-runtime-interfaces.ci.cloudfoundry.org"}"
 debug "SYSTEM_DOMAIN: ${SYSTEM_DOMAIN}"
 system_domain="${SYSTEM_DOMAIN}"