chore: replace ifrit with stdlib runner - #1182
Draft
silvestre wants to merge 2 commits into
Draft
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
silvestre
added
the
skip-dependency-postprocessing
# Issue `ifrit` (`github.com/tedsuo/ifrit`) is not maintained. # Fix Replace `ifrit` with a small internal `helpers/runner` package built on Go stdlib (`context`, `net/http`, `os/signal`). The package provides the same primitives that `ifrit` did: a `Runner` interface, a `RunFunc` adapter, named `Member` structs, and `StartOrdered` for ordered startup with LIFO graceful shutdown triggered by `SIGINT`/`SIGTERM` or context cancellation. A companion `helpers/runner/testrunner` package replaces `ginkgomon_v2` for tests, offering `Invoke`/`Interrupt`/`Kill` helpers for in-process runners and a `CmdRunner` that starts external binaries and waits for a configurable start-check string in their combined stdout+stderr before signalling ready. All five Go services (`api`, `eventgenerator`, `scalingengine`, `metricsforwarder`, `operator`) and the shared `startup`, `sync`, and `helpers` packages are updated accordingly. `ifrit` is removed from `go.mod`.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
ifrit(github.com/tedsuo/ifrit) is not maintained.Fix
Replace
ifritwith a small internalhelpers/runnerpackage built on Go stdlib(
context,net/http,os/signal). The package provides the same primitivesthat
ifritdid: aRunnerinterface, aRunFuncadapter, namedMemberstructs,and
StartOrderedfor ordered startup with LIFO graceful shutdown triggered bySIGINT/SIGTERMor context cancellation.A companion
helpers/runner/testrunnerpackage replacesginkgomon_v2for tests,offering
Invoke/Interrupt/Killhelpers for in-process runners and aCmdRunnerthat starts external binaries and waits for a configurable start-checkstring in their combined stdout+stderr before signalling ready.
All five Go services (
api,eventgenerator,scalingengine,metricsforwarder,operator) and the sharedstartup,sync, andhelperspackages are updatedaccordingly.
ifritis removed fromgo.mod.