feat: add OrgManager user support to acceptance test framework - #1266
Merged
Conversation
- Add org-manager user configuration to acceptance test config - Per-node teardown in AfterSuite to prevent space deletion races - Accept 403 status in deletePolicy for org-manager users - Add disk write timing test assertion - Update cleanup helpers for shared org environments
This was referenced Jun 17, 2026
- Fix broken Makefile echo referencing deleted variable - Use DeferCleanup for occupier.Stop to prevent goroutine leak on assertion failure - Fix CleanupInExistingOrg to resolve GUID per-space (was reusing space[0] GUID for all spaces) - Remove dead UseExistingOrganization guard inside CleanupInExistingOrg (caller already branches) - Add Bool() method on BoolOrInt; use it in isUpdatable()
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
asalan316
reviewed
Jun 24, 2026
asalan316
reviewed
Jun 25, 2026
asalan316
reviewed
Jun 25, 2026
- Add Expect(Exit(0)) assertion in getSpaceGuidByName to fail fast on CF command errors instead of silently returning empty string - Rename spaceGuidByte -> spaceGuidCmd to match the Session type - Fix race condition in CleanupInExistingOrg: use GetRawSpaces to resolve name+GUID atomically, eliminating separate getSpaceGuidByName call that could fail when parallel Ginkgo nodes delete spaces concurrently
- GetTestSpaces now delegates to filterTestSpaces instead of duplicating the HasPrefix loop - BoolOrInt.UnmarshalJSON checks first byte to branch on bool vs int, avoiding a failed json.Unmarshal attempt on every non-bool value
asalan316
approved these changes
Jun 25, 2026
bonzofenix
enabled auto-merge (squash)
June 25, 2026 09:42
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Introduces org-manager user concept to acceptance tests, enabling tests to run with limited permissions (OrgManager instead of admin).
Changes
acceptance/config/config.go: Add OrgManager user config fieldsacceptance/helpers/cleanup.go: Per-node teardown to prevent space deletion racesacceptance/helpers/org.go: Org helper for shared org environmentsacceptance/api/api_test.go: Accept 403 in deletePolicy for org-manageracceptance/broker/broker_test.go: Adapt broker tests for org-manageracceptance/assets/app/go_app/internal/app/disk_test.go: Disk write timing assertionTesting
Part 2 of 4 — Split from #1149 for easier review.