Skip to content

Commit 9f2fbda

Browse files
authored
Merge pull request #691 from geofffranks/enhance-log-jobs-help
Update help messaging for bosh logs --jobs and bosh logs --only to explain the differences
2 parents 4b13dc7 + a90911a commit 9f2fbda

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

cmd/opts/opts.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -877,8 +877,8 @@ type LogsOpts struct {
877877
Num int `long:"num" description:"Last number of lines"`
878878
Quiet bool `long:"quiet" short:"q" description:"Suppresses printing of headers when multiple files are being examined"`
879879

880-
Jobs []string `long:"job" description:"Limit to only specific jobs"`
881-
Filters []string `long:"only" description:"Filter logs (comma-separated)"`
880+
Jobs []string `long:"job" description:"Limit to only specific jobs (can only be used in combination with --follow)"`
881+
Filters []string `long:"only" description:"Filter logs to specific jobs (comma-separated). Like --jobs, but for when --follow is not being used"`
882882
Agent bool `long:"agent" description:"Include only agent logs"`
883883
System bool `long:"system" description:"Include only system logs"`
884884
All bool `long:"all-logs" description:"Include all logs (agent, system, and job logs)"`

cmd/opts/opts_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2629,15 +2629,15 @@ var _ = Describe("Opts", func() {
26292629
Describe("Jobs", func() {
26302630
It("contains desired values", func() {
26312631
Expect(getStructTagForName("Jobs", opts)).To(Equal(
2632-
`long:"job" description:"Limit to only specific jobs"`,
2632+
`long:"job" description:"Limit to only specific jobs (can only be used in combination with --follow)"`,
26332633
))
26342634
})
26352635
})
26362636

26372637
Describe("Filters", func() {
26382638
It("contains desired values", func() {
26392639
Expect(getStructTagForName("Filters", opts)).To(Equal(
2640-
`long:"only" description:"Filter logs (comma-separated)"`,
2640+
`long:"only" description:"Filter logs to specific jobs (comma-separated). Like --jobs, but for when --follow is not being used"`,
26412641
))
26422642
})
26432643
})

0 commit comments

Comments
 (0)