Refactor ssh option passing

ai-assisted=yes
[TNZ-94640]

Signed-off-by: Aram Price <aram.price@broadcom.com>

Author: selzoc

ssh/ssh_args.go

@@ -56,7 +56,7 @@ func NewSSHArgs(connOpts ConnectionOpts, result boshdir.SSHResult, forceTTY bool
 }
 
 func (a SSHArgs) LoginForHost(host boshdir.Host) []string {
-	return []string{host.Host, "-l", host.Username}
+	return []string{"-l", host.Username, "--", host.Host}
 }
 
 func formProxyOpt(existenceChecker cmdExistenceChecker, proxyHostString string) string {

ssh/ssh_args_test.go

@@ -44,13 +44,13 @@ var _ = Describe("SSHArgs", func() {
 			return SSHArgs{}.LoginForHost(host)
 		}
 
-		It("returns login details with IPv4", func() {
-			Expect(act()).To(Equal([]string{"127.0.0.1", "-l", "user"}))
+		It("returns login details with IPv4, placing '--' before host to stop option parsing", func() {
+			Expect(act()).To(Equal([]string{"-l", "user", "--", "127.0.0.1"}))
 		})
 
-		It("returns login details with IPv6 non-bracketed", func() {
+		It("returns login details with IPv6, placing '--' before host to stop option parsing", func() {
 			host.Host = "::1"
-			Expect(act()).To(Equal([]string{"::1", "-l", "user"}))
+			Expect(act()).To(Equal([]string{"-l", "user", "--", "::1"}))
 		})
 	})