bosh-stemcell: move deps to gemspec remove unused gems

- add Rakefile for gem
- update testing to use `rake spec`
- dev dependency gems are removed from cache
- add rake task to cover --tag shellout_types
- remove `logger` gem as it is not used
- remove vendored gems as the only gem needed now is `rake`

Author: aramprice

.bundle/config

@@ -11,5 +11,5 @@ jobs:
     - name: test-bosh-stemcell
       run: |
         bundle install
-        bundle exec rspec
+        bundle exec rake
       working-directory: bosh-stemcell/

.gitattributes

@@ -1,12 +1,4 @@
 source 'https://rubygems.org'
 
-group :development, :test do
-  gem 'bosh-stemcell', path: 'bosh-stemcell'
-  gem 'fakefs'
-  gem 'logging'
-  gem 'rake'
-  gem 'rspec'
-  gem 'rspec-instafail'
-  gem 'rspec-its'
-  gem 'timecop'
-end
+gem 'rake'
+gem 'bosh-stemcell', path: 'bosh-stemcell'

.github/workflows/ruby.yml

@@ -6,46 +6,14 @@ PATH
 GEM
   remote: https://rubygems.org/
   specs:
-    diff-lcs (1.6.2)
-    fakefs (3.2.1)
-    little-plugger (1.1.4)
-    logging (2.4.0)
-      little-plugger (~> 1.1)
-      multi_json (~> 1.14)
-    multi_json (1.19.1)
     rake (13.3.1)
-    rspec (3.13.2)
-      rspec-core (~> 3.13.0)
-      rspec-expectations (~> 3.13.0)
-      rspec-mocks (~> 3.13.0)
-    rspec-core (3.13.6)
-      rspec-support (~> 3.13.0)
-    rspec-expectations (3.13.5)
-      diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.13.0)
-    rspec-instafail (1.0.0)
-      rspec
-    rspec-its (2.0.0)
-      rspec-core (>= 3.13.0)
-      rspec-expectations (>= 3.13.0)
-    rspec-mocks (3.13.8)
-      diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.13.0)
-    rspec-support (3.13.7)
-    timecop (0.9.10)
 
 PLATFORMS
   ruby
 
 DEPENDENCIES
   bosh-stemcell!
-  fakefs
-  logging
   rake
-  rspec
-  rspec-instafail
-  rspec-its
-  timecop
 
 BUNDLED WITH
    2.5.23

Gemfile

@@ -174,23 +174,23 @@ locally, run:
 ```shell
 bundle install --local
 cd /opt/bosh/bosh-stemcell
-OS_IMAGE=/opt/bosh/tmp/ubuntu_base_image.tgz bundle exec rspec spec/ --tag shellout_types
+OS_IMAGE=/opt/bosh/tmp/ubuntu_base_image.tgz bundle exec rake spec:shellout_types
 ```
 
 If on macOS, run:
 
 ```shell
-OSX=true OS_IMAGE=/opt/bosh/tmp/ubuntu_base_image.tgz bundle exec rspec spec/ --tag shellout_types
+OSX=true OS_IMAGE=/opt/bosh/tmp/ubuntu_base_image.tgz bundle exec rake spec:shellout_types
 ```
 
 ### How to run tests for BOSH Linux Stemcell Builder
 
 The BOSH Linux Stemcell Builder code itself can be tested with the following command's:
 
 ```shell
-bundle install --local
 cd /opt/bosh/bosh-stemcell
-bundle exec rspec spec/
+bundle install
+bundle exec rake
 ```
 
 ## Troubleshooting

Gemfile.lock

@@ -1,5 +1,4 @@
 require 'json'
-require 'logging'
 
 namespace :stemcell do
   desc 'Build a base OS image for use in stemcells'

README.md

@@ -0,0 +1,3 @@
+source 'https://rubygems.org'
+
+gemspec

Rakefile

@@ -0,0 +1,11 @@
+require "rspec/core/rake_task"
+
+task default: [:spec]
+
+RSpec::Core::RakeTask.new(:spec)
+
+namespace :spec do
+  RSpec::Core::RakeTask.new(:shellout_types) do |t|
+    t.rspec_opts = "--tag shellout_types"
+  end
+end

bosh-stemcell/Gemfile

@@ -19,4 +19,12 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = %w[lib]
+
+  spec.add_development_dependency 'fakefs'
+  spec.add_development_dependency 'rake'
+  spec.add_development_dependency 'rspec'
+  spec.add_development_dependency 'rspec-instafail'
+  spec.add_development_dependency 'rspec-its'
+  spec.add_development_dependency 'standard'
+  spec.add_development_dependency 'timecop'
 end