Skip to content

Fix shell quoting in make-raw-from-heavy-stemcell.sh: use [ -n "${AWS_ACCESS_KEY_ID}" ] instead of [ ! -z "$AWS_ACCESS_KEY_ID" ] #662

Description

@coderabbitai

Summary

In ci/tasks/light-google/make-raw-from-heavy-stemcell.sh, the condition on line 22 uses the deprecated ! -z form with an unquoted variable:

if [ ! -z "$AWS_ACCESS_KEY_ID" ]; then

This should be updated to use -n with proper brace-quoting for consistency with the strict quoting/hardening standards applied throughout the rest of the script:

if [ -n "${AWS_ACCESS_KEY_ID}" ]; then

This was flagged during review of PR #660 (targeting the ubuntu-noble branch). The fix should be applied against the ubuntu-jammy branch first, then merged forward.

References

/cc @aramprice

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type
No fields configured for issues without a type.

Projects

Status
Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions