Summary
In ci/tasks/light-google/make-raw-from-heavy-stemcell.sh, the condition on line 22 uses the deprecated ! -z form with an unquoted variable:
if [ ! -z "$AWS_ACCESS_KEY_ID" ]; then
This should be updated to use -n with proper brace-quoting for consistency with the strict quoting/hardening standards applied throughout the rest of the script:
if [ -n "${AWS_ACCESS_KEY_ID}" ]; then
This was flagged during review of PR #660 (targeting the ubuntu-noble branch). The fix should be applied against the ubuntu-jammy branch first, then merged forward.
References
/cc @aramprice
Summary
In
ci/tasks/light-google/make-raw-from-heavy-stemcell.sh, the condition on line 22 uses the deprecated! -zform with an unquoted variable:This should be updated to use
-nwith proper brace-quoting for consistency with the strict quoting/hardening standards applied throughout the rest of the script:This was flagged during review of PR #660 (targeting the ubuntu-noble branch). The fix should be applied against the
ubuntu-jammybranch first, then merged forward.References
/cc @aramprice