Merge jammy

[aramprice]

No description provided.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 836f195c-f459-46d3-b023-36df7fecf715

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch merge-jammy

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[linux-foundation-easycla]

• ✅ login: aramprice / name: aram price (037b146, 0806fab, 137df55, 44e1e1b, 5bc9f63, 62e0e36, 6f0a721, add91a8, af56b89, bb375ad, c82bdee, cd1edc8, d69fd55, f0cd334, f56d3fa, 229001f)
• ✅ login: dependabot[bot] / name: dependabot[bot] (196cb0a)
• ❌ The email address for the commit (2382aa4, 2d879e0, 435c123, 47f4f95, 4c90383, 851b2e4, 87117e8, c349422, c4685af, cb67658, f978dc3, fe2ab98, feb7c16) is not linked to the GitHub account, preventing the EasyCLA check. Consult this Help Article and GitHub Help to resolve. (To view the commit's email address, add .patch at the end of this PR page's URL.) For further assistance with EasyCLA, please submit a support request ticket.
• ❌ - login: @cf-rabbit-bot / name: CI Bot . The commit (d4fd5c2) is not authorized under a signed CLA. Please click here to be authorized. For further assistance with EasyCLA, please submit a support request ticket.

[coderabbitai]

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@bosh-stemcell/lib/shellout_types/file.rb`:
- Around line 79-101: The final permission check uses the original `mode`
causing an extra/stat and inconsistent snapshot; change the fallback expression
to use the previously-captured `this_mode` instead (i.e., replace the final
`(mode & 0o004) != 0` with `(this_mode & 0o004) != 0`) in the method that uses
`this_mode`, `owned_by?(username)`, `group_entry` and `@chroot.run` so the
function consistently uses the single captured mode value.

In `@bosh-stemcell/spec/bosh/stemcell/build_environment_spec.rb`:
- Around line 23-24: Remove the duplicate test helper by keeping a single
let(:version) declaration and deleting the shadowing one; locate both
occurrences of let(:version) in build_environment_spec (the top-level
let(:version) and the later redeclaration) and remove the latter so the test
uses a single, unambiguous version value (ensure any tests relying on the second
value are updated to use the sole let(:version) or an explicitly named helper if
different values are required).

In `@README.md`:
- Around line 176-179: The README currently instructs to run `bundle install
--local` before `rake spec:shellout_types`, which fails without a local vendor
cache; update the setup steps to use a normal bundle install that fetches gems
(e.g., `bundle install` or `bundle install --path vendor/bundle`) so the `rake
spec:shellout_types` invocation succeeds; specifically change the `bundle
install --local` line in the README to a non-local install command and ensure
any subsequent commands (like `cd /opt/bosh/bosh-stemcell` and `OS_IMAGE=...
bundle exec rake spec:shellout_types`) remain the same.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 8f76fd2e-d7fd-48f7-b333-d39064e4f798

📥 Commits

Reviewing files that changed from the base of the PR and between aac6489 and c82bdee.

⛔ Files ignored due to path filters (1)

• Gemfile.lock is excluded by !**/*.lock

📒 Files selected for processing (119)

• .bundle/config
• .gitattributes
• .github/workflows/ruby.yml
• .rubocop.yml
• Gemfile
• README.md
• Rakefile
• bosh-stemcell/.rubocop.yml
• bosh-stemcell/Gemfile
• bosh-stemcell/Rakefile
• bosh-stemcell/bosh-stemcell.gemspec
• bosh-stemcell/lib/bosh/core/shell.rb
• bosh-stemcell/lib/bosh/stemcell/arch.rb
• bosh-stemcell/lib/bosh/stemcell/archive.rb
• bosh-stemcell/lib/bosh/stemcell/archive_filename.rb
• bosh-stemcell/lib/bosh/stemcell/aws/region.rb
• bosh-stemcell/lib/bosh/stemcell/build_environment.rb
• bosh-stemcell/lib/bosh/stemcell/builder_options.rb
• bosh-stemcell/lib/bosh/stemcell/definition.rb
• bosh-stemcell/lib/bosh/stemcell/disk_image.rb
• bosh-stemcell/lib/bosh/stemcell/infrastructure.rb
• bosh-stemcell/lib/bosh/stemcell/operating_system.rb
• bosh-stemcell/lib/bosh/stemcell/os_image_builder.rb
• bosh-stemcell/lib/bosh/stemcell/stage_collection.rb
• bosh-stemcell/lib/bosh/stemcell/stage_runner.rb
• bosh-stemcell/lib/bosh/stemcell/stemcell_builder.rb
• bosh-stemcell/lib/bosh/stemcell/stemcell_packager.rb
• bosh-stemcell/lib/bosh/stemcell/version.rb
• bosh-stemcell/lib/shellout_types/chroot.rb
• bosh-stemcell/lib/shellout_types/file.rb
• bosh-stemcell/lib/shellout_types/group.rb
• bosh-stemcell/lib/shellout_types/package.rb
• bosh-stemcell/lib/shellout_types/service.rb
• bosh-stemcell/lib/shellout_types/user.rb
• bosh-stemcell/spec/bosh/stemcell/archive_filename_spec.rb
• bosh-stemcell/spec/bosh/stemcell/archive_handler_spec.rb
• bosh-stemcell/spec/bosh/stemcell/archive_spec.rb
• bosh-stemcell/spec/bosh/stemcell/build_environment_spec.rb
• bosh-stemcell/spec/bosh/stemcell/builder_options_spec.rb
• bosh-stemcell/spec/bosh/stemcell/definition_spec.rb
• bosh-stemcell/spec/bosh/stemcell/disk_image_spec.rb
• bosh-stemcell/spec/bosh/stemcell/helpers_sh_spec.rb
• bosh-stemcell/spec/bosh/stemcell/infrastructure_spec.rb
• bosh-stemcell/spec/bosh/stemcell/operating_system_spec.rb
• bosh-stemcell/spec/bosh/stemcell/os_image_builder_spec.rb
• bosh-stemcell/spec/bosh/stemcell/stage_collection_spec.rb
• bosh-stemcell/spec/bosh/stemcell/stage_runner_spec.rb
• bosh-stemcell/spec/bosh/stemcell/stemcell_builder_spec.rb
• bosh-stemcell/spec/bosh/stemcell/stemcell_packager_spec.rb
• bosh-stemcell/spec/bosh/stemcell_spec.rb
• bosh-stemcell/spec/os_image/ubuntu_spec.rb
• bosh-stemcell/spec/shellout_types/chroot_spec.rb
• bosh-stemcell/spec/shellout_types/command_spec.rb
• bosh-stemcell/spec/shellout_types/file_spec.rb
• bosh-stemcell/spec/shellout_types/group_spec.rb
• bosh-stemcell/spec/shellout_types/package_spec.rb
• bosh-stemcell/spec/shellout_types/service_spec.rb
• bosh-stemcell/spec/shellout_types/spec_helper.rb
• bosh-stemcell/spec/shellout_types/user_spec.rb
• bosh-stemcell/spec/spec_helper.rb
• bosh-stemcell/spec/stemcells/alicloud_spec.rb
• bosh-stemcell/spec/stemcells/aws_spec.rb
• bosh-stemcell/spec/stemcells/azure_spec.rb
• bosh-stemcell/spec/stemcells/cis_spec.rb
• bosh-stemcell/spec/stemcells/cloudstack_spec.rb
• bosh-stemcell/spec/stemcells/fips_spec.rb
• bosh-stemcell/spec/stemcells/go_agent_spec.rb
• bosh-stemcell/spec/stemcells/google_spec.rb
• bosh-stemcell/spec/stemcells/openstack_spec.rb
• bosh-stemcell/spec/stemcells/stig_spec.rb
• bosh-stemcell/spec/stemcells/ubuntu_spec.rb
• bosh-stemcell/spec/stemcells/vsphere_spec.rb
• bosh-stemcell/spec/stemcells/warden_spec.rb
• bosh-stemcell/spec/support/be_valid_json_file_matcher.rb
• bosh-stemcell/spec/support/cis.rb
• bosh-stemcell/spec/support/os_image.rb
• bosh-stemcell/spec/support/os_image_chrony_shared_examples.rb
• bosh-stemcell/spec/support/os_image_linux_kernel_modules_shared_examples.rb
• bosh-stemcell/spec/support/os_image_linux_kernel_shared_examples.rb
• bosh-stemcell/spec/support/os_image_shared_examples.rb
• bosh-stemcell/spec/support/os_image_systemd_shared_examples.rb
• bosh-stemcell/spec/support/os_image_ubuntu_shared_examples.rb
• bosh-stemcell/spec/support/os_image_upstart_shared_examples.rb
• bosh-stemcell/spec/support/shellout_type_assertions.rb
• bosh-stemcell/spec/support/spec_assets.rb
• bosh-stemcell/spec/support/spec_ordering.rb
• bosh-stemcell/spec/support/stemcell_image.rb
• bosh-stemcell/spec/support/stemcell_shared_examples.rb
• bosh-stemcell/spec/support/stemcell_tarball.rb
• bosh-stemcell/spec/support/stig.rb
• bosh-stemcell/spec/support/udf_module_disabled.rb
• ci/docker/os-image-stemcell-builder/Dockerfile
• ci/tasks/test-unit.sh
• vendor/cache/diff-lcs-1.6.2.gem
• vendor/cache/fakefs-3.2.1.gem
• vendor/cache/little-plugger-1.1.4.gem
• vendor/cache/logging-2.4.0.gem
• vendor/cache/rake-13.3.1.gem
• vendor/cache/rspec-3.13.2.gem
• vendor/cache/rspec-core-3.13.6.gem
• vendor/cache/rspec-expectations-3.13.5.gem
• vendor/cache/rspec-instafail-1.0.0.gem
• vendor/cache/rspec-its-2.0.0.gem
• vendor/cache/rspec-mocks-3.13.8.gem
• vendor/cache/rspec-support-3.13.7.gem
• vendor/cache/timecop-0.9.10.gem
• vendor/package/diff-lcs-1.6.2.gem
• vendor/package/fakefs-3.2.1.gem
• vendor/package/little-plugger-1.1.4.gem
• vendor/package/logging-2.4.0.gem
• vendor/package/rake-13.3.1.gem
• vendor/package/rspec-3.13.2.gem
• vendor/package/rspec-core-3.13.6.gem
• vendor/package/rspec-expectations-3.13.5.gem
• vendor/package/rspec-instafail-1.0.0.gem
• vendor/package/rspec-its-2.0.0.gem
• vendor/package/rspec-mocks-3.13.8.gem
• vendor/package/rspec-support-3.13.7.gem
• vendor/package/timecop-0.9.10.gem

💤 Files with no reviewable changes (18)

• .bundle/config
• Rakefile
• .gitattributes
• vendor/cache/rspec-its-2.0.0.gem
• bosh-stemcell/spec/support/spec_ordering.rb
• .rubocop.yml
• vendor/cache/little-plugger-1.1.4.gem
• bosh-stemcell/.rubocop.yml
• vendor/cache/rspec-instafail-1.0.0.gem
• vendor/cache/rspec-core-3.13.6.gem
• vendor/cache/diff-lcs-1.6.2.gem
• vendor/cache/timecop-0.9.10.gem
• vendor/cache/logging-2.4.0.gem
• vendor/cache/rspec-expectations-3.13.5.gem
• vendor/cache/rspec-mocks-3.13.8.gem
• vendor/cache/fakefs-3.2.1.gem
• vendor/cache/rspec-3.13.2.gem
• vendor/cache/rspec-support-3.13.7.gem