StemcellBuilder needs to bundle install now

[aramprice]

No description provided.

[coderabbitai]

Walkthrough

This change modifies the RSpec test execution workflow for the bosh-stemcell project by adding an explicit bundle install step before running tests. The bundle install command is inserted into both OS image and stemcell RSpec command sequences in the build environment configuration. Supporting changes include updates to the test expectations in the build environment spec and removal of the rspec-instafail development dependency from the gemspec. Documentation in the README is also updated to reflect the new bundle install step in the test execution instructions.

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check	❓ Inconclusive	No description was provided by the author, making it impossible to assess relevance to the changeset.	Add a pull request description explaining the rationale for requiring bundle install in the RSpec commands.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'StemcellBuilder needs to bundle install now' accurately describes the main change—adding bundle install steps to the stemcell builder's RSpec command sequences.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix-add-bundle-install

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

README.md (1)

152-157: ⚠️ Potential issue | 🟠 Major

Fix the stemcell test snippet: environment variables are parsed as bundle install arguments instead of being passed to rspec.

Lines 152–153 use backslash continuation after bundle install, causing the subsequent STEMCELL_IMAGE=..., STEMCELL_WORKDIR=..., and OS_NAME=... tokens to be parsed as arguments to bundle install rather than environment variables for bundle exec rspec. The && operator must separate these command sequences.

Proposed fix

-cd /opt/bosh/bosh-stemcell; \
-bundle install \
+cd /opt/bosh/bosh-stemcell && \
+bundle install && \
 STEMCELL_IMAGE=/mnt/stemcells/vsphere/esxi/ubuntu/work/work/vsphere-esxi-ubuntu.raw \
 STEMCELL_WORKDIR=/mnt/stemcells/vsphere/esxi/ubuntu/work/work/chroot \
 OS_NAME=ubuntu \
 bundle exec rspec -fd --tag ~exclude_on_vsphere \

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@README.md` around lines 152 - 157, The shell snippet currently uses
backslashes after "bundle install", causing the following tokens
(STEMCELL_IMAGE, STEMCELL_WORKDIR, OS_NAME) to be treated as arguments to
"bundle install" instead of environment variables for "bundle exec rspec";
change the command separation so "bundle install" completes (e.g., end that line
and use &&) and ensure STEMCELL_IMAGE, STEMCELL_WORKDIR, and OS_NAME are
exported or prefixed before "bundle exec rspec" (or use ENV_VAR=... && bundle
exec rspec) so those variables are passed only to the "bundle exec rspec"
invocation.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Outside diff comments:
In `@README.md`:
- Around line 152-157: The shell snippet currently uses backslashes after
"bundle install", causing the following tokens (STEMCELL_IMAGE,
STEMCELL_WORKDIR, OS_NAME) to be treated as arguments to "bundle install"
instead of environment variables for "bundle exec rspec"; change the command
separation so "bundle install" completes (e.g., end that line and use &&) and
ensure STEMCELL_IMAGE, STEMCELL_WORKDIR, and OS_NAME are exported or prefixed
before "bundle exec rspec" (or use ENV_VAR=... && bundle exec rspec) so those
variables are passed only to the "bundle exec rspec" invocation.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: af81fc5f-1025-4c0a-b704-8a12d3e83234

📥 Commits

Reviewing files that changed from the base of the PR and between 229001f and 680eff0.

📒 Files selected for processing (4)

• README.md
• bosh-stemcell/bosh-stemcell.gemspec
• bosh-stemcell/lib/bosh/stemcell/build_environment.rb
• bosh-stemcell/spec/bosh/stemcell/build_environment_spec.rb

💤 Files with no reviewable changes (1)

• bosh-stemcell/bosh-stemcell.gemspec