Skip to content

Fix: invoke bundler in sudo#550

Merged
aramprice merged 1 commit into
ubuntu-jammyfrom
fix-bundle
Apr 14, 2026
Merged

Fix: invoke bundler in sudo#550
aramprice merged 1 commit into
ubuntu-jammyfrom
fix-bundle

Conversation

@aramprice

Copy link
Copy Markdown
Member

No description provided.

@coderabbitai

coderabbitai Bot commented Apr 14, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 5fa8e86d-c299-46e2-821b-8ce522af2cb0

📥 Commits

Reviewing files that changed from the base of the PR and between af56b89 and 716000b.

📒 Files selected for processing (1)
  • ci/tasks/os-images/build.sh

Walkthrough

The build script in ci/tasks/os-images/ has been refactored to use stack-based directory navigation with pushd/popd commands instead of direct cd operations. The bundle install execution within ${REPO_ROOT}/bosh-stemcell and the bundle exec rake stemcell:build_os_image command within the privileged sudo section are now performed using explicit stack-based directory changes. This replaces the previous approach of changing to ${REPO_ROOT} and running the rake command from the root directory. The script now concludes with a newline character.

Suggested reviewers

  • fmoehler
  • a-hassanin
  • rkoster
🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No description was provided by the author, making it impossible to assess relatedness to the changeset. Add a description explaining why bundler needs to be invoked under sudo and what issue this fixes.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: moving bundler invocation to run under sudo privileges in the build script.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-bundle

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@aramprice aramprice merged commit 62e0e36 into ubuntu-jammy Apr 14, 2026
12 checks passed
@aramprice aramprice deleted the fix-bundle branch April 14, 2026 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant