Skip to content

Fix: rake, rspec, etc are non-dev dependencies#552

Merged
aramprice merged 1 commit into
ubuntu-jammyfrom
separate-gem-specs-from-stemcell-specs
Apr 14, 2026
Merged

Fix: rake, rspec, etc are non-dev dependencies#552
aramprice merged 1 commit into
ubuntu-jammyfrom
separate-gem-specs-from-stemcell-specs

Conversation

@aramprice

Copy link
Copy Markdown
Member

No description provided.

@coderabbitai

coderabbitai Bot commented Apr 14, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: d12655ff-dfe1-4bdb-99ac-3a4cd3b47866

📥 Commits

Reviewing files that changed from the base of the PR and between 44e1e1b and 20417fd.

⛔ Files ignored due to path filters (1)
  • Gemfile.lock is excluded by !**/*.lock
📒 Files selected for processing (7)
  • bosh-stemcell/bosh-stemcell.gemspec
  • bosh-stemcell/lib/bosh/stemcell/build_environment.rb
  • bosh-stemcell/spec/bosh/stemcell/build_environment_spec.rb
  • bosh-stemcell/spec/bosh/stemcell/stage_runner_spec.rb
  • bosh-stemcell/spec/spec_helper.rb
  • ci/tasks/build.sh
  • ci/tasks/os-images/build.sh
💤 Files with no reviewable changes (2)
  • bosh-stemcell/spec/spec_helper.rb
  • bosh-stemcell/lib/bosh/stemcell/build_environment.rb

Walkthrough

This pull request reorganizes gem dependency management and dependency installation in the bosh-stemcell project. The gemspec now declares rake, rspec, and rspec-its as runtime dependencies instead of development-only dependencies. The bundle install step is removed from RSpec command generation in build_environment.rb, and CI scripts are updated to run bundle install from the project root directory rather than from the bosh-stemcell subdirectory. The fakefs/spec_helpers require is relocated from the global spec helper to specific test files that need it.

Suggested reviewers

  • ragaskar
  • ystros
🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No description was provided, making it impossible to evaluate relevance to the changeset. Provide a pull request description explaining the rationale for reclassifying these dependencies and any related changes.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically summarizes the main change: moving rake, rspec, and rspec-its from development to runtime dependencies.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch separate-gem-specs-from-stemcell-specs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@aramprice aramprice merged commit d69fd55 into ubuntu-jammy Apr 14, 2026
12 checks passed
@aramprice aramprice deleted the separate-gem-specs-from-stemcell-specs branch April 14, 2026 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant