Go agent suffix defaulting lives in pipeline config

[aramprice]

No description provided.

[coderabbitai]

Warning

Rate limit exceeded

@aramprice has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 45 minutes and 2 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 45 minutes and 2 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 7d745111-213a-445b-9039-cfc74b9df1d2

📥 Commits

Reviewing files that changed from the base of the PR and between 344a78a and ed73992.

📒 Files selected for processing (4)

• ci/pipelines/builder.yml
• ci/pipelines/vars.yml
• ci/tasks/build.sh
• ci/tasks/build.yml

Walkthrough

The pull request refactors how AGENT_SUFFIX is supplied across the CI pipeline. The builder.yml pipeline configuration now explicitly provides AGENT_SUFFIX: "-go_agent" to the build_stemcell task. The build.yml task definition removes the default AGENT_SUFFIX value. The build.sh script eliminates internal defaulting of AGENT_SUFFIX, updates parameter interpolation within rake task arguments, and modifies stemcell artifact naming conventions and meta4 path directory structures.

Suggested reviewers

• mkocher
• lnguyen

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The pull request description is missing entirely. The repository requires a description following the 'Merge Forward' strategy template, but none was provided.	Add a detailed pull request description explaining the changes and confirming whether this is the initial PR or a merge-forward PR, following the provided template guidelines.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the main change: moving Go agent suffix defaulting from task config to pipeline config.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch go-agent-suffix

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

This PR moves the defaulting of the -go_agent suffix out of the reusable Concourse task and into the pipeline configuration, so different pipelines/jobs can control whether the suffix is present.

Changes:

• Removes the AGENT_SUFFIX default from ci/tasks/build.yml and from ci/tasks/build.sh.
• Sets AGENT_SUFFIX explicitly in ci/pipelines/builder.yml (currently to -go_agent).
• Minor shell formatting/consistency updates in the build task (variable bracing in rake args, consistent hyphen-separated string interpolation).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
ci/tasks/build.yml	Stops defaulting AGENT_SUFFIX in the shared task params.
ci/tasks/build.sh	Removes bash-level fallback default for AGENT_SUFFIX; keeps suffix usage in artifact naming.
ci/pipelines/builder.yml	Sets AGENT_SUFFIX at the pipeline/job level (now the source of truth for the default).

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

This PR moves the default “go agent” suffix configuration out of the build task/script and into the pipeline’s configurable vars, so the pipeline can centrally control whether (and how) the agent suffix is applied to produced stemcell artifacts and index/meta4 paths.

Changes:

• Remove the hard-coded -go_agent default from the build task definition and the build task script.
• Introduce stemcell_details.agent_suffix in pipeline vars and thread it through pipeline places that previously hard-coded -go_agent.
• Update meta4 naming, stemcell name used for BATS config, and publish copy key patterns to use the configured suffix.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File	Description
ci/tasks/build.yml	Stops defaulting AGENT_SUFFIX in the task params to shift defaulting responsibility to the pipeline.
ci/tasks/build.sh	Removes script-side defaulting of AGENT_SUFFIX and keeps artifact/meta4 naming driven by the env value.
ci/pipelines/vars.yml	Adds stemcell_details.agent_suffix (default "-go_agent") as the single source of truth.
ci/pipelines/builder.yml	Replaces hard-coded -go_agent usage with data.values.stemcell_details.agent_suffix across build/upload/filter/publish/bats usage.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.