Skip to content

ci: remove parallel in publish#604

Merged
aramprice merged 1 commit into
ubuntu-jammyfrom
ci-fixup
May 29, 2026
Merged

ci: remove parallel in publish#604
aramprice merged 1 commit into
ubuntu-jammyfrom
ci-fixup

Conversation

@aramprice

Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings May 29, 2026 22:37
@coderabbitai

coderabbitai Bot commented May 29, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

The PR reformats the publisher pipeline YAML in the publish-... job's parallel execution plan. The put steps for publishing heavy stemcells, optional FIPS stemcells, and AWS light stemcells are restructured to use a consistent params-then-put layout pattern. The file globs, metadata message, rename patterns, version inputs, and AWS AMI tagging task parameters remain unchanged; only the YAML structure is adjusted for consistency.

Suggested reviewers

  • mkocher
  • ystros
  • ramonskie
🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Description check ⚠️ Warning No pull request description was provided by the author, violating the repository's merge-forward strategy guidelines that require clear documentation of changes. Add a description explaining the purpose of the reformatting changes and confirm which branch this should be merged into following the merge-forward strategy.
Title check ❓ Inconclusive The title mentions 'remove parallel' but the changes appear to be reformatting/restructuring put steps with params-then-put patterns, not actually removing parallelism. Clarify whether parallelism is actually being removed or if this is a restructuring change, and update the title to accurately reflect the main objective.
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci-fixup

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the publisher Concourse pipeline to run the publish steps sequentially instead of inside a single in_parallel block.

Changes:

  • Removed the in_parallel wrapper around heavy, FIPS, AWS light publish, and AWS AMI tagging steps.
  • Preserved the existing publish/tag step definitions and ordering as standalone plan steps.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@ci/pipelines/publisher.yml`:
- Line 556: The commented line "#!  - file:
bosh-stemcells-ci/ci/tasks/light-aws/tag-aws-ami-light.yml" has inconsistent
indentation (two spaces after "#!"); edit that comment to match surrounding
commented entries by removing the extra space so it reads "#! - file:
bosh-stemcells-ci/ci/tasks/light-aws/tag-aws-ami-light.yml" (ensure other
similar comment lines use the same "#! - file:" pattern).
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: e6037ab0-c48c-43cf-ab0d-6ea25814481b

📥 Commits

Reviewing files that changed from the base of the PR and between 6f0c8a8 and 7ec6376.

📒 Files selected for processing (1)
  • ci/pipelines/publisher.yml

Comment thread ci/pipelines/publisher.yml
@aramprice aramprice merged commit abf298f into ubuntu-jammy May 29, 2026
13 checks passed
@aramprice aramprice deleted the ci-fixup branch May 29, 2026 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants