Remove CentOS-specific code and assets#620
Conversation
CentOS stemcells are no longer built, so this drops dead stages, assets, and code paths. Also removes the default_su_directive override (already removed on ubuntu-noble), which silently overrode the correct 'su root syslog' set globally in ubuntu-logrotate.conf.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (12)
💤 Files with no reviewable changes (8)
WalkthroughThis PR removes CentOS as a supported Linux distribution from the BOSH Linux stemcell builder while enhancing security policies for remaining supported distributions. The changes include removing CentOS from distribution detection logic, eliminating CentOS-specific logrotate configuration assets and directives, updating PAM authentication and password policies with faillock and cracklib modules, and refreshing infrastructure documentation examples from CentOS to Ubuntu paths. Suggested reviewers
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
cf-foundation-community-automation
Bot
moved this to Inbox
in Foundational Infrastructure Working Group
github-project-automation
Bot
moved this from Inbox
to Pending Merge | Prioritized
in Foundational Infrastructure Working Group
There was a problem hiding this comment.
Pull request overview
Removes remaining CentOS-specific stages/assets and related code paths from the stemcell builder and test suite, reflecting that CentOS stemcells are no longer produced. It also drops the logrotate default_su_directive override so the globally configured su root syslog behavior is no longer silently replaced.
Changes:
- Deleted CentOS-only stages and security/logrotate assets (PAM patches, logrotate config, CentOS audit stage).
- Removed installation of
/etc/logrotate.d/default_su_directiveand the corresponding spec. - Updated distro detection and inline documentation examples to no longer mention CentOS.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| stemcell_builder/stages/system_open_vm_tools/apply.sh | Removes outdated CentOS-only installation note. |
| stemcell_builder/stages/password_policies/assets/centos/system-auth.patch | Removes CentOS-only PAM patch asset. |
| stemcell_builder/stages/password_policies/assets/centos/password-auth.patch | Removes CentOS-only PAM patch asset. |
| stemcell_builder/stages/logrotate_config/assets/default_su_directive | Removes CentOS workaround that overrode the intended global su directive behavior. |
| stemcell_builder/stages/logrotate_config/assets/centos-logrotate.conf | Removes CentOS-only logrotate configuration asset. |
| stemcell_builder/stages/logrotate_config/apply.sh | Stops installing the removed default_su_directive file. |
| stemcell_builder/stages/image_install_grub/apply.sh | Updates comment examples to use Ubuntu paths instead of CentOS. |
| stemcell_builder/stages/image_install_grub_softlayer_two_partitions/apply.sh | Updates comment examples to use Ubuntu paths instead of CentOS. |
| stemcell_builder/stages/image_install_grub_efi/apply.sh | Updates comment examples to use Ubuntu paths instead of CentOS. |
| stemcell_builder/stages/bosh_audit_centos/apply.sh | Removes CentOS-specific audit stage script. |
| bosh-stemcell/spec/support/stemcell_shared_examples.rb | Removes spec that asserted presence/content of default_su_directive. |
| bosh-stemcell/lib/shellout_types/service.rb | Removes CentOS from distro allowlist used by service enablement checks. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
aramprice
left a comment
aramprice
left a comment
There was a problem hiding this comment.
Looks good, thank you for tackling this!
Wondering if we should also remove this test for rpm, or is it relevant because of openSUSE?
describe package("rpm") do
it { should_not be_installed }
end
|
Hi @aramprice, This is something I planned to bring up on the community meeting. If we confirm that SUSE is also not being used, we can do the cleanup separately. I would like to go over the other repositories as well and do the same, especially the docs-bosh. Where is the correct place to open an issue to track the clean up? |
|
Maybe an umbrella issue would be best in the community repo? I'm not certain though. |
github-project-automation
Bot
moved this from Pending Merge | Prioritized
to Done
in Foundational Infrastructure Working Group
CentOS stemcells are no longer built, so this drops dead stages, assets, and code paths. Also removes the default_su_directive override (already removed on ubuntu-noble), which silently overrode the correct 'su root syslog' set globally in ubuntu-logrotate.conf.