CI: pass SHLVL to make ~ubuntu/.bash_logout succeed#627
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughThis PR updates two CI build scripts (ci/tasks/build.sh and ci/tasks/os-images/build.sh) to add SHLVL to the sudo --preserve-env list used in heredoc invocations and to remove the interactive Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Updates the CI task wrappers that sudo to the ubuntu user so the login shell exits cleanly by preserving SHLVL in the environment, avoiding failures triggered by ~ubuntu/.bash_logout.
Changes:
- Preserve
SHLVLinsudo --preserve-envfor theubuntusubshell used to runbundle/rake. - Switch the
ubuntusubshell invocation frombash --login -itobash --login.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| ci/tasks/os-images/build.sh | Preserve SHLVL for the ubuntu login shell used to build OS images; drop interactive bash flag. |
| ci/tasks/build.sh | Preserve SHLVL for the ubuntu login shell used to build stemcells; drop interactive bash flag. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
NOTE: this repository uses a "Merge Forward" strategy
Changes should be made in the earliest applicable branch, and
merged forward through subsequent branches.
ubuntu-<short_name>)merge-to-<next_short_name>branchubuntu-<short_name>intomerge-to-<next_short_name>merge-to-<next_short_name>intoubuntu-<next_short_name>