Skip to content

Add NVMe support to Alicloud infrastructure configuration#639

Merged
neddp merged 1 commit into
cloudfoundry:ubuntu-noblefrom
Ivaylogi98:ubuntu-noble-add-support-for-nvme-on-ali
Jun 12, 2026
Merged

Add NVMe support to Alicloud infrastructure configuration#639
neddp merged 1 commit into
cloudfoundry:ubuntu-noblefrom
Ivaylogi98:ubuntu-noble-add-support-for-nvme-on-ali

Conversation

@Ivaylogi98

Copy link
Copy Markdown
Contributor

NOTE: this repository uses a "Merge Forward" strategy. This PR is merge forwarded from ubuntu-jammy - #635

Add nvme_support cloud property for AliCloud stemcells

AliCloud instance families (c9i, g9i, r9i) require stemcell images to have Features.NvmeSupport=supported set in ECS. Previously the CPI was enabling this unconditionally for all AliCloud stemcells, which couples infrastructure-specific behaviour to the CPI rather than to the stemcell definition.

This change adds "nvme_support": "supported" to Alicloud#additional_cloud_properties in the infrastructure definition. The value is written into cloud_properties in stemcell.MF at build time, alongside the existing root_device_name property. CPIs can read this field to decide whether to enable NVMe support when importing or copying a stemcell image, rather than inferring it from the infrastructure name.

No other infrastructure is affected.

Changes

  • bosh-stemcell/lib/bosh/stemcell/infrastructure.rb — added "nvme_support" => "supported" to Alicloud#additional_cloud_properties
  • bosh-stemcell/spec/bosh/stemcell/infrastructure_spec.rb — added missing describe Infrastructure::Alicloud block with nvme_support assertion (the AliCloud infrastructure had no unit tests before this change)

@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 885282f7-37c5-4aaa-9dcf-20ecb920d019

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-project-automation github-project-automation Bot moved this from Inbox to Pending Merge | Prioritized in Foundational Infrastructure Working Group Jun 12, 2026
@neddp neddp merged commit 1a534a4 into cloudfoundry:ubuntu-noble Jun 12, 2026
4 checks passed
@github-project-automation github-project-automation Bot moved this from Pending Merge | Prioritized to Done in Foundational Infrastructure Working Group Jun 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants