Skip to content

Fix test stemcells#648

Closed
mkocher wants to merge 6 commits into
ubuntu-resolutefrom
fix-test-stemcells
Closed

Fix test stemcells#648
mkocher wants to merge 6 commits into
ubuntu-resolutefrom
fix-test-stemcells

Conversation

@mkocher

@mkocher mkocher commented Jun 18, 2026

Copy link
Copy Markdown
Member

Assorted fixes to make test-stemcells pass for the first time:

  • add bpm to acceptance tests manifest since syslog requires it on Resolute
  • fix some test cleanup code
  • fix some pam spec failures

mkocher and others added 6 commits June 13, 2026 19:58
@mkocher
add bpm to acceptance test manifests, bump vars to noble
ca3b434
@mkocher
remove --all from cleanup
853fb6b 
The pipeline already runs `bosh clean-up --all` in the teardown
step. Removing this allos BPM to be uploaded once. It also makes
the tests faster as the releases don't have to be recompiled
for each suite.
@mkocher
better pam error logging, handle Resolute sa1 location
e79280f
@aramprice @mkocher
fix: migrate changes from HEREDOC to agent.json
0b7c35e
@mkocher
fix libpam-lastlog2
d6c36ba 
this seems like a bug in the libpam-lastlog2 package
@mkocher
ci: add bpm release as syslog now depends on it
e688d3c
@coderabbitai

coderabbitai Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 3aa606f8-af34-410e-98c3-75bfefeac15e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-test-stemcells

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

aramprice
aramprice previously approved these changes Jun 18, 2026
View reviewed changes
@aramprice aramprice changed the base branch from ubuntu-resolute to ubuntu-jammy June 18, 2026 22:31
@aramprice aramprice dismissed their stale review June 18, 2026 22:31

The base branch was changed.

@aramprice aramprice changed the base branch from ubuntu-jammy to ubuntu-resolute June 18, 2026 22:33
@aramprice

aramprice commented Jun 18, 2026

Copy link
Copy Markdown
Member

backported to jammy

@aramprice aramprice closed this Jun 18, 2026
@aramprice aramprice deleted the fix-test-stemcells branch June 18, 2026 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aramprice aramprice aramprice left review comments

Assignees

No one assigned

Labels

None yet

Projects

Foundational Infrastructure Working Group
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mkocher @aramprice