assorted pipeline and test improvements

[mkocher]

• add bpm to acceptance test manifests as syslog will depend on it
• remove --all from cleanup - the pipeline already runs bosh clean-up --all in the teardown step. Removing this allows BPM to be uploaded once. It also makes the tests faster as the releases don't have to be recompiled for each suite.
• better pam error logging, handle Resolute sa1 location
• fix libpam-lastlog2 - this seems like a bug in the libpam-lastlog2 package

[coderabbitai]

Caution

Review failed

Pull request was closed or merged during review

Walkthrough

This PR integrates the BPM release as a dependency for acceptance tests and the CI pipeline. A new bpm-release resource is added to the CI pipeline, wired through the task definition and shell script via BPM_RELEASE_PATH, and both ipv4director smoke and syslogrelease acceptance-test BOSH manifests are updated to include the bpm release and job. The syslogrelease BeforeSuite now uploads the BPM release before running tests.

Additionally, several Ubuntu 26.04+ compatibility fixes are included: a symlink is created in the chroot to make pam_lastlog2.so reachable from PAM's securedir when only the multiarch path exists; the sysstat sa1 binary path selection is updated to check /usr/libexec/sysstat/sa1 first; the auth.log assertion is refined to extract and report only lines containing the error string; and the BOSH teardown no longer passes --all to clean-up.

Suggested Reviewers

• aramprice

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title 'assorted pipeline and test improvements' is vague and generic, using the non-descriptive term 'assorted' that doesn't convey meaningful information about the specific changes.	Provide a more specific title that captures the main focus, such as 'Add BPM release support and optimize acceptance tests' or 'Improve pipeline efficiency by adding BPM and optimizing cleanup'.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description check	✅ Passed	The pull request description clearly outlines the four main changes (BPM addition, cleanup optimization, PAM error logging, libpam-lastlog2 fix) with explanations of their rationale and benefits.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch assorted-ci-fixes

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}