Combine pipelines

[aramprice]

Combines publisher => builder pipeline

Includes fix for bad permssion on ci/tasks/light-aws/cleanup-ami.sh.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[coderabbitai]

Warning

Review limit reached

@aramprice, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 49 minutes and 5 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more credits in the billing tab to continue.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: c4e65c38-cb68-40ca-8d44-b2963e0ec608

📥 Commits

Reviewing files that changed from the base of the PR and between 603bf3e and c2e1cea.

📒 Files selected for processing (6)

• README.md
• ci/configure.sh
• ci/pipeline-template.yml
• ci/pipeline-vars.yml
• ci/pipelines/publisher.yml
• docs/new_stemcell_line.md

Walkthrough

ci/configure.sh is rewritten to remove interactive pipeline file discovery and selection; it now uses fixed paths (ci/pipeline-template.yml, ci/pipeline-vars.yml) and derives the pipeline name from STEMCELL_LINE. ci/pipelines/publisher.yml (759 lines) is deleted, and its light stemcell build/cleanup/publish jobs and ytt template helpers are absorbed into ci/pipeline-template.yml. Across all existing jobs in the template, bosh-integration-image is replaced with bosh-integration-registry-image, CI bot YAML anchors are replaced with explicit bot_email/bot_name template values, and new resources (terraform_type, metalink stemcell candidates/published, every-week-on-monday, bosh-release, aws-light-stemcell-builder-registry-image, gce-cpi-release-registry-image) are added. A README link to the pipeline vars file is updated to reflect the new path.

Suggested reviewers

• mkocher
• ystros
• rkoster

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	The description is brief but complete, covering the main change (combining pipelines) and an additional fix, though it doesn't follow the repository's Merge Forward strategy template which requires branch information.	Clarify which stemcell branch this PR targets (e.g., ubuntu-<short_name-N>) and confirm the Merge Forward strategy path for subsequent merges.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'Combine pipelines' directly summarizes the main change: merging publisher and builder pipelines into a single pipeline.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch combine-pipelines

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@ci/pipeline-template.yml`:
- Around line 1021-1024: Remove the empty `do:` block from the `in_parallel`
section in the pipeline template. The bare `- do:` with no subsequent steps is a
no-op that should be deleted. Keep only the two `build_light_aws_stemcell_new`
template calls as siblings within the parallel execution block.
- Around line 1099-1100: The author_email value in the ci_bot_email anchor is
hardcoded to `bots@cloudfoundry.org` instead of using the template variable `(@=
data.values.stemcell_details.bot_email @)` which is used consistently throughout
the rest of the file and resolves to the correct value from
ci/pipeline-vars.yml. Replace the hardcoded email address for the author_email
anchor definition with the template variable to ensure consistent bot authorship
across all commits.

In `@README.md`:
- Line 352: The markdown link in README.md has a mismatch between the display
text and the hyperlink target. The display text shows the old path
"ci/pipelines/vars.yml" while the hyperlink target points to the new path
"ci/pipeline-vars.yml". Update the display text within the square brackets to
match the new path in the parentheses, changing "ci/pipelines/vars.yml" to
"ci/pipeline-vars.yml" to ensure consistency between what users see and where
the link directs them.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 6d1caed0-2dcb-4aa6-af39-50ac894c9367

📥 Commits

Reviewing files that changed from the base of the PR and between 718a56e and 603bf3e.

📒 Files selected for processing (6)

• README.md
• ci/configure.sh
• ci/pipeline-template.yml
• ci/pipeline-vars.yml
• ci/pipelines/publisher.yml
• ci/tasks/light-aws/cleanup-ami.sh

💤 Files with no reviewable changes (1)

• ci/pipelines/publisher.yml