Implement RFC-0027: Add max_route_options_size BOSH property (#630)

* Implement RFC-0027: Add max_route_options_size BOSH property

Adds the cc.max_route_options_size BOSH property (default: 1024 bytes)
to control the maximum allowed size of route options JSON payloads.

- Add cc.max_route_options_size property to cloud_controller_ng job spec
- Expose property via cloud_controller_internal BOSH link
- Map property into cloud_controller_ng.yml.erb for api job
- Map property into cloud_controller_ng.yml.erb for worker job (via link)
- Include git-sourced gem directories in cloud_controller_ng package spec

* Add max_route_options_size to worker spec link fixture

Author: rkoster

jobs/cloud_controller_ng/spec

@@ -149,6 +149,7 @@ provides:
   - cc.default_stack
   - cc.default_app_lifecycle
   - cc.disable_private_domain_cross_space_context_path_route_sharing
+  - cc.max_route_options_size
   - cc.droplets.blobstore_provider
   - cc.droplets.blobstore_type
   - cc.droplets.cdn.key_pair_id
@@ -1143,6 +1144,10 @@ properties:
     description: "Disallow route collisions over shared private domains when created in different spaces"
     default: false
 
+  cc.max_route_options_size:
+    description: "Maximum size in bytes for the serialized route options JSON. Routes with options exceeding this limit will be rejected with HTTP 422 Unprocessable Entity. See RFC-0027 for details on tuning this alongside route emit interval."
+    default: 1024
+
   cc.core_file_pattern:
     description: "Filename template for core dump files. Use an empty string if you don't want core files saved."
     default: "/var/vcap/sys/cores/core-%e-%s-%p-%t"

jobs/cloud_controller_ng/templates/cloud_controller_ng.yml.erb

@@ -86,6 +86,7 @@ custom_root_links.to_json
 
 reserved_private_domains: <%= p("cc.reserved_private_domains", nil) %>
 disable_private_domain_cross_space_context_path_route_sharing: <%= p("cc.disable_private_domain_cross_space_context_path_route_sharing", false) %>
+max_route_options_size: <%= p("cc.max_route_options_size") %>
 
 jobs:
   enable_dynamic_job_priorities: <%= p("cc.jobs.enable_dynamic_job_priorities") %>

jobs/cloud_controller_worker/templates/cloud_controller_ng.yml.erb

@@ -372,6 +372,7 @@ system_domain: <%= p("system_domain") %>
 system_hostnames: <%= link("cloud_controller_internal").p("cc.system_hostnames") %>
 
 disable_private_domain_cross_space_context_path_route_sharing: <%= link("cloud_controller_internal").p("cc.disable_private_domain_cross_space_context_path_route_sharing") %>
+max_route_options_size: <%= link("cloud_controller_internal").p("cc.max_route_options_size") %>
 
 max_service_credential_bindings_per_app_service_instance: <%= link("cloud_controller_internal").p("cc.max_service_credential_bindings_per_app_service_instance") %>
 

spec/cloud_controller_worker/cloud_controller_worker_spec.rb

@@ -74,6 +74,7 @@ module Test
               },
               'max_labels_per_resource' => true,
               'max_annotations_per_resource' => 'yus',
+              'max_route_options_size' => 1024,
               'disable_private_domain_cross_space_context_path_route_sharing' => false,
               'cpu_weight_min_memory' => 128,
               'cpu_weight_max_memory' => 8192,