Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions jobs/cloud_controller_ng/spec
Original file line number Diff line number Diff line change
Expand Up @@ -111,10 +111,6 @@ provides:
- cc.mutual_tls.ca_cert
- cc.prom_metrics_server_tls_port
- cc.prom_scraper_tls.ca_cert
- name: cloud_controller_container_networking_info
type: cloud_controller_container_networking_info
properties:
- cc.internal_route_vip_range
- name: cloud_controller_internal
type: cloud_controller_internal
properties:
Expand Down Expand Up @@ -216,7 +212,6 @@ provides:
- cc.temporary_enable_v2
- cc.tls_port
- cc.uaa.client_timeout
- cc.internal_route_vip_range
- cc.volume_services_enabled
- credhub_api.ca_cert
- credhub_api.hostname
Expand Down Expand Up @@ -1273,14 +1268,6 @@ properties:
description: "Controls whether CredHub credentials are automatically interpolated in VCAP_SERVICES"
default: true

cc.internal_route_vip_range:
default: "127.128.0.0/9"
description: "The IPv4 CIDR range of virtual IP addresses to be assigned to routes on internal domains.
WARNING: Changing this range is not supported, and has undefined behaviors.
It is recommended to leave this value as the default.
If this range is changed, it is likely the routes on the internal service mesh domain
will need to be recreated."

cc.log_audit_events:
default: true
description: "Log audit events"
Expand Down
10 changes: 0 additions & 10 deletions jobs/cloud_controller_ng/templates/cloud_controller_ng.yml.erb
Original file line number Diff line number Diff line change
Expand Up @@ -569,16 +569,6 @@ perm:
max_labels_per_resource: <%= p("cc.max_labels_per_resource") %>
max_annotations_per_resource: <%= p("cc.max_annotations_per_resource") %>

<%
internal_vip_range = p("cc.internal_route_vip_range")
raise StandardError.new("invalid cc.internal_route_vip_range: #{internal_vip_range}") unless internal_vip_range =~ /\A (?:\d{1,3}\.){3} \d{1,3} \/ \d{1,3} \z/x

parts = internal_vip_range.split(/[\.\/]/).map(&:to_i)
raise StandardError.new("invalid cc.internal_route_vip_range: #{internal_vip_range}") if parts[0..3].any? {|x| x > 255} || parts[4] > 32
%>

internal_route_vip_range: <%= internal_vip_range %>

threadpool_size: <%= p("cc.experimental.thin_server.thread_pool_size") %>

default_app_lifecycle: <%= p("cc.default_app_lifecycle") %>
Expand Down
8 changes: 0 additions & 8 deletions jobs/cloud_controller_worker/spec
Original file line number Diff line number Diff line change
Expand Up @@ -583,14 +583,6 @@ properties:
description: "Maximum PID limit for containerized work running user-provided code"
default: 1024

cc.internal_route_vip_range:
default: "127.128.0.0/9"
description: "The IPv4 CIDR range of virtual IP addresses to be assigned to routes on internal domains.
WARNING: Changing this range is not supported, and has undefined behaviors.
It is recommended to leave this value as the default.
If this range is changed, it is likely the routes on the internal service mesh domain
will need to be recreated."

cc.loggregator.internal_url:
description: "Internal URL used to communicate with traffic_controller"
default: "http://loggregator-trafficcontroller.service.cf.internal:8081"
Expand Down
10 changes: 0 additions & 10 deletions jobs/cloud_controller_worker/templates/cloud_controller_ng.yml.erb
Original file line number Diff line number Diff line change
Expand Up @@ -342,16 +342,6 @@ perform_blob_cleanup: <%= p("cc.perform_blob_cleanup") %>
system_domain: <%= p("system_domain") %>
system_hostnames: <%= link("cloud_controller_internal").p("cc.system_hostnames") %>

<%
internal_vip_range = p("cc.internal_route_vip_range")
raise StandardError.new("invalid cc.internal_route_vip_range: #{internal_vip_range}") unless internal_vip_range =~ /\A (?:\d{1,3}\.){3} \d{1,3} \/ \d{1,3} \z/x

parts = internal_vip_range.split(/[\.\/]/).map(&:to_i)
raise StandardError.new("invalid cc.internal_route_vip_range: #{internal_vip_range}") if parts[0..3].any? {|x| x > 255} || parts[4] > 32
%>

internal_route_vip_range: <%= internal_vip_range %>

disable_private_domain_cross_space_context_path_route_sharing: <%= link("cloud_controller_internal").p("cc.disable_private_domain_cross_space_context_path_route_sharing") %>

max_labels_per_resource: <%= link("cloud_controller_internal").p("cc.max_labels_per_resource") %>
Expand Down
29 changes: 0 additions & 29 deletions spec/cloud_controller_ng/cloud_controller_ng_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -195,35 +195,6 @@ module Test
end
end

describe 'internal route vip range' do
it 'has a default range' do
rendered_hash = YAML.safe_load(template.render(merged_manifest_properties, consumes: links))
expect(rendered_hash['internal_route_vip_range']).to eq('127.128.0.0/9')
end

describe 'when a range is specified in manifest properties' do
it 'validates they are valid CIDRs' do
merged_manifest_properties['cc']['internal_route_vip_range'] = '10.16.255.0/777'
expect do
YAML.safe_load(template.render(merged_manifest_properties, consumes: links))
end.to raise_error(StandardError, 'invalid cc.internal_route_vip_range: 10.16.255.0/777')
end

it 'does not allow ipv6 addresses' do
merged_manifest_properties['cc']['internal_route_vip_range'] = '2001:0db8:85a3:0000:0000:8a2e:0370:7334/21'
expect do
YAML.safe_load(template.render(merged_manifest_properties, consumes: links))
end.to raise_error(StandardError, 'invalid cc.internal_route_vip_range: 2001:0db8:85a3:0000:0000:8a2e:0370:7334/21')
end

it 'renders valid CIDRs' do
merged_manifest_properties['cc']['internal_route_vip_range'] = '10.16.255.0/24'
rendered_hash = YAML.safe_load(template.render(merged_manifest_properties, consumes: links))
expect(rendered_hash['internal_route_vip_range']).to eq('10.16.255.0/24')
end
end
end

describe 'database_encryption block' do
context 'when the database_encryption block is not present' do
before do
Expand Down