Skip to content

Commit fcd2b5f

Browse files
authored
Merge pull request #1996 from cloudfoundry/dependabot/maven/assets/spring-sleuth/develop/org.springframework.boot-spring-boot-starter-parent-4.1.0
build(deps): bump org.springframework.boot:spring-boot-starter-parent from 3.4.5 to 4.1.0 in /assets/spring-sleuth
2 parents 39e7498 + 8a88842 commit fcd2b5f

6 files changed

Lines changed: 27 additions & 15 deletions

File tree

.github/workflows/build-spring-sleuth-jar.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ jobs:
2525
uses: actions/setup-java@v5
2626
with:
2727
distribution: temurin
28-
java-version: "17"
28+
java-version: "21"
2929
cache: maven
3030

3131
- name: Build jar with Maven

assets/spring-sleuth/pom.xml

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
<parent>
77
<groupId>org.springframework.boot</groupId>
88
<artifactId>spring-boot-starter-parent</artifactId>
9-
<version>3.4.5</version>
9+
<version>4.1.0</version>
1010
<relativePath/>
1111
</parent>
1212

@@ -17,7 +17,7 @@
1717
<description>Modern tracing sample replacing legacy Spring Cloud Sleuth SpanAccessor usage</description>
1818

1919
<properties>
20-
<java.version>17</java.version>
20+
<java.version>21</java.version>
2121
</properties>
2222

2323
<dependencies>
@@ -30,8 +30,8 @@
3030
<artifactId>spring-boot-starter-actuator</artifactId>
3131
</dependency>
3232
<dependency>
33-
<groupId>io.micrometer</groupId>
34-
<artifactId>micrometer-tracing-bridge-otel</artifactId>
33+
<groupId>org.springframework.boot</groupId>
34+
<artifactId>spring-boot-micrometer-tracing-opentelemetry</artifactId>
3535
</dependency>
3636
<dependency>
3737
<groupId>io.opentelemetry</groupId>
@@ -42,6 +42,11 @@
4242
<artifactId>spring-boot-starter-test</artifactId>
4343
<scope>test</scope>
4444
</dependency>
45+
<dependency>
46+
<groupId>org.springframework.boot</groupId>
47+
<artifactId>spring-boot-webmvc-test</artifactId>
48+
<scope>test</scope>
49+
</dependency>
4550
</dependencies>
4651

4752
<build>

assets/spring-sleuth/src/test/java/hello/HelloControllerTest.java

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@
77

88
import org.junit.jupiter.api.Test;
99
import org.springframework.beans.factory.annotation.Autowired;
10-
import org.springframework.boot.test.autoconfigure.web.servlet.AutoConfigureMockMvc;
1110
import org.springframework.boot.test.context.SpringBootTest;
11+
import org.springframework.boot.webmvc.test.autoconfigure.AutoConfigureMockMvc;
1212
import org.springframework.test.web.servlet.MockMvc;
1313

1414
@SpringBootTest
@@ -21,11 +21,10 @@ class HelloControllerTest {
2121
@Test
2222
void returnsTraceAndSpanDetailsAndParentFromTraceparent() throws Exception {
2323
mvc.perform(get("/")
24-
.header("traceparent", "00-4bf92f3577b34da6a3ce929d0e0e4736-00f067aa0ba902b7-01"))
25-
.andExpect(status().isOk())
26-
.andExpect(content().string(containsString("current span: [Trace:")))
27-
.andExpect(content().string(containsString("Span:")))
28-
.andExpect(content().string(containsString("parents: [00f067aa0ba902b7]")));
24+
.header("traceparent", "00-4bf92f3577b34da6a3ce929d0e0e4736-00f067aa0ba902b7-01"))
25+
.andExpect(status().isOk())
26+
.andExpect(content().string(containsString("current span: [Trace:")))
27+
.andExpect(content().string(containsString("Span:")))
28+
.andExpect(content().string(containsString("parents: [00f067aa0ba902b7]")));
2929
}
30-
}
31-
30+
}
-1.64 MB
Binary file not shown.

cats_suite_helpers/cats_suite_helpers.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -214,7 +214,7 @@ func RoutingIsolationSegmentsDescribe(description string, callback func()) bool
214214
}
215215

216216
func ZipkinDescribe(description string, callback func()) bool {
217-
return Describe("[routing]", func() {
217+
return Describe("[zipkin]", func() {
218218
BeforeEach(func() {
219219
if !Config.GetIncludeRouting() {
220220
Skip(skip_messages.SkipRoutingMessage)

routing/zipkin_tracing.go

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,16 @@ var _ = ZipkinDescribe("Zipkin Tracing", func() {
3131
"-b", Config.GetJavaBuildpackName(),
3232
"-m", "1024M",
3333
"-p", assetPath,
34+
"--no-start",
3435
"-t", "120",
35-
).Wait(CF_JAVA_TIMEOUT)).To(gexec.Exit(0))
36+
).Wait(Config.CfPushTimeoutDuration())).To(gexec.Exit(0))
37+
38+
Expect(cf.Cf(
39+
"set-env", appName,
40+
"JBP_CONFIG_OPEN_JDK_JRE", `{ jre: { version: 21.+ } }`,
41+
).Wait()).To(gexec.Exit(0))
42+
43+
Expect(cf.Cf("start", appName).Wait(CF_JAVA_TIMEOUT)).To(gexec.Exit(0))
3644
})
3745

3846
AfterEach(func() {

0 commit comments

Comments
 (0)