Draft
Conversation
|
|
svkrieger
force-pushed
the
enhance-cats-sb
branch
2 times, most recently
from
edee120 to
2f9ad80
Compare
- The behaviour for a fetch service instance can now be controlled with `fetch_service_instance` - The behaviour for a fetch service binding can now be controlled with `fetch_service_instance` - The behaviour for a fetch service instance last operation can now be controlled with `fetch_service_instance_last_operation` - The behaviour for a fetch service binding last operation can now be controlled with `fetch_service_binding_last_operation` - Improved error responses in case a service instance or service binding does not exist but the resource or its last operation is being fetched - Improved overriding the response json with configuration
svkrieger
force-pushed
the
enhance-cats-sb
branch
from
2f9ad80 to
2415465
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this change about?
While working on cloudfoundry/cloud_controller_ng#3589 I realised that the cats broker's response to a request trying to fetch a service binding's last operation cannot be configured. Same was true for fetching a service instance's and service binding's data. This was needed to verify the CC's behaviour for different responses of the service broker.
This PR changes/improves the following:
The behaviour for a fetch service instance can now be controlled with
fetch_service_instanceThe behaviour for a fetch service binding can now be controlled with
fetch_service_instanceThe behaviour for a fetch service instance last operation can now be controlled with
fetch_service_instance_last_operationThe behaviour for a fetch service binding last operation can now be controlled with
fetch_service_binding_last_operationImproved error responses in case a service instance or service binding does not exist but the resource or its last operation is being fetched
Improved overriding the response json with configuration
Please provide contextual information.
While these changes were made to analyse the CC's behaviour, which is described in cloudfoundry/cloud_controller_ng#3589, it will be helpful for enhancing the cats tests itself in the future to have this behaviour verified whenever the cats run.
What version of cf-deployment have you run this cf-acceptance-test change against?
Please check all that apply for this PR:
Did you update the README as appropriate for this change?
If you are introducing a new acceptance test, what is your rationale for including it CATs rather than your own acceptance test suite?
CATs should validate common operator workflows.
CATs is not a regression test suite.
CATs is run by every component team to validate their releases before promotion.
How many more (or fewer) seconds of runtime will this change introduce to CATs?
What is the level of urgency for publishing this change?
Tag your pair, your PM, and/or team!
It's helpful to tag a few other folks on your team or your team alias in case we need to follow up later.