DefaultApplications: remove unused methods

Author: Kehrlann

cloudfoundry-operations/src/main/java/org/cloudfoundry/operations/applications/DefaultApplications.java

@@ -160,7 +160,6 @@
 import org.cloudfoundry.util.DelayTimeoutException;
 import org.cloudfoundry.util.ExceptionUtils;
 import org.cloudfoundry.util.FileUtils;
-import org.cloudfoundry.util.FluentMap;
 import org.cloudfoundry.util.JobUtils;
 import org.cloudfoundry.util.PaginationUtils;
 import org.cloudfoundry.util.ResourceMatchingUtils;
@@ -280,9 +279,7 @@ public Mono<Void> copySource(CopySourceApplicationRequest request) {
     @Override
     public Mono<Void> delete(DeleteApplicationRequest request) {
         return getRoutesAndApplicationId(
-                        request,
-                        spaceId,
-                        Optional.ofNullable(request.getDeleteRoutes()).orElse(false))
+                        request, Optional.ofNullable(request.getDeleteRoutes()).orElse(false))
                 .flatMap(
                         function(
                                 (routes, applicationId) ->
@@ -710,14 +707,6 @@ private Mono<Boolean> getSshEnabled(String applicationId) {
                 .map(GetApplicationSshEnabledResponse::getEnabled);
     }
 
-    private static Map<String, Object> addToEnvironment(
-            Map<String, Object> environment, String variableName, Object variableValue) {
-        return FluentMap.<String, Object>builder()
-                .entries(environment)
-                .entry(variableName, variableValue)
-                .build();
-    }
-
     private Mono<Void> applyDropletAndWaitForRunning(
             String appname, String appId, String dropletId) {
         return this.cloudFoundryClient
@@ -987,7 +976,7 @@ private static String eventDescription(Map<String, Object> request, String... en
                 sb.append(", ");
             }
             first = false;
-            sb.append(entryName).append(": ").append(String.valueOf(value));
+            sb.append(entryName).append(": ").append(value);
         }
         return sb.toString();
     }
@@ -1175,10 +1164,6 @@ private static String[] getEntryNames(String type) {
         return type.contains("crash") ? ENTRY_FIELDS_CRASH : ENTRY_FIELDS_NORMAL;
     }
 
-    private static Map<String, Object> getEnvironment(AbstractApplicationResource resource) {
-        return ResourceUtils.getEntity(resource).getEnvironmentJsons();
-    }
-
     private static int getInstances(AbstractApplicationResource resource) {
         return Optional.ofNullable(resource.getEntity())
                 .map(ApplicationEntity::getInstances)
@@ -1362,8 +1347,7 @@ private Mono<List<org.cloudfoundry.client.v2.routes.Route>> getRoutes(String app
     }
 
     private Mono<Tuple2<Optional<List<org.cloudfoundry.client.v2.routes.Route>>, String>>
-            getRoutesAndApplicationId(
-                    DeleteApplicationRequest request, String spaceId, boolean deleteRoutes) {
+            getRoutesAndApplicationId(DeleteApplicationRequest request, boolean deleteRoutes) {
         return getApplicationId(request.getName())
                 .flatMap(
                         applicationId ->
@@ -1607,13 +1591,6 @@ private Flux<Void> pushDocker(
                                         applicationId, manifest.getName(), request));
     }
 
-    private static Map<String, Object> removeFromEnvironment(
-            Map<String, Object> environment, String variableName) {
-        Map<String, Object> modified = new HashMap<>(environment);
-        modified.remove(variableName);
-        return modified;
-    }
-
     private Mono<Void> removeServiceBindings(String applicationId) {
         return requestListServiceBindings(applicationId)
                 .map(ResourceUtils::getId)
@@ -2191,17 +2168,6 @@ private Mono<UpdateApplicationEnvironmentVariablesResponse> requestUnsetEnvironm
                                 .build());
     }
 
-    private Mono<AbstractApplicationResource> requestUpdateApplicationHealthCheckType(
-            String applicationId, ApplicationHealthCheck type) {
-        return requestUpdateApplication(
-                applicationId, builder -> builder.healthCheckType(type.getValue()));
-    }
-
-    private Mono<AbstractApplicationResource> requestUpdateApplicationName(
-            String applicationId, String name) {
-        return requestUpdateApplication(applicationId, builder -> builder.name(name));
-    }
-
     private Mono<ApplicationFeature> requestUpdateApplicationSsh(
             String applicationId, boolean enabled) {
         return requestUpdateApplicationFeature(
@@ -2228,11 +2194,6 @@ private Mono<AbstractApplicationResource> requestUpdateApplicationScale(
                 builder -> builder.diskQuota(disk).instances(instances).memory(memory));
     }
 
-    private Mono<AbstractApplicationResource> requestUpdateApplicationSsh(
-            String applicationId, Boolean enabled) {
-        return requestUpdateApplication(applicationId, builder -> builder.enableSsh(enabled));
-    }
-
     private Mono<AbstractApplicationResource> requestUpdateApplicationState(
             String applicationId, String state) {
         return requestUpdateApplication(applicationId, builder -> builder.state(state));

cloudfoundry-operations/src/test/java/org/cloudfoundry/operations/applications/DefaultApplicationsTest.java

@@ -4783,43 +4783,6 @@ private static void requestApplicationProcesses(
                                         .build()));
     }
 
-    private static void requestApplicationsWithSsh(
-            CloudFoundryClient cloudFoundryClient,
-            String application,
-            String spaceId,
-            Boolean sshEnabled) {
-        when(cloudFoundryClient
-                        .spaces()
-                        .listApplications(
-                                ListSpaceApplicationsRequest.builder()
-                                        .name(application)
-                                        .spaceId(spaceId)
-                                        .page(1)
-                                        .build()))
-                .thenReturn(
-                        Mono.just(
-                                fill(ListSpaceApplicationsResponse.builder())
-                                        .resource(
-                                                ApplicationResource.builder()
-                                                        .metadata(
-                                                                fill(Metadata.builder())
-                                                                        .id("test-application-id")
-                                                                        .build())
-                                                        .entity(
-                                                                fill(
-                                                                                ApplicationEntity
-                                                                                        .builder(),
-                                                                                "application-")
-                                                                        .environmentJson(
-                                                                                "test-var",
-                                                                                "test-value")
-                                                                        .enableSsh(sshEnabled)
-                                                                        .build())
-                                                        .build())
-                                        .totalPages(1)
-                                        .build()));
-    }
-
     private static void requestAssociateRoute(
             CloudFoundryClient cloudFoundryClient, String applicationId, String routeId) {
         when(cloudFoundryClient