Skip to content

Commit 1446d37

Browse files
issue-1242 fixing version of PaginatedRequest implemented by v3._ListSecurityGroupsRequest and adding an integration test case
1 parent 197c8f4 commit 1446d37

File tree

2 files changed

+25
-1
lines changed

2 files changed

+25
-1
lines changed

cloudfoundry-client/src/main/java/org/cloudfoundry/client/v3/securitygroups/_ListSecurityGroupsRequest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414

1515
package org.cloudfoundry.client.v3.securitygroups;
1616

17-
import org.cloudfoundry.client.v2.PaginatedRequest;
17+
import org.cloudfoundry.client.v3.PaginatedRequest;
1818
import org.immutables.value.Value;
1919
import org.cloudfoundry.client.v3.FilterParameter;
2020
import org.cloudfoundry.Nullable;

integration-test/src/test/java/org/cloudfoundry/client/v3/SecurityGroupsTest.java

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@
1818

1919
import java.time.Duration;
2020
import java.util.Arrays;
21+
import java.util.Collections;
22+
2123
import org.cloudfoundry.AbstractIntegrationTest;
2224
import org.cloudfoundry.client.CloudFoundryClient;
2325
import org.cloudfoundry.client.v3.securitygroups.BindRunningSecurityGroupRequest;
@@ -34,6 +36,7 @@
3436
import org.cloudfoundry.client.v3.securitygroups.UnbindRunningSecurityGroupRequest;
3537
import org.cloudfoundry.client.v3.securitygroups.UnbindStagingSecurityGroupRequest;
3638
import org.cloudfoundry.client.v3.securitygroups.UpdateSecurityGroupRequest;
39+
import org.cloudfoundry.util.PaginationUtils;
3740
import org.junit.jupiter.api.BeforeEach;
3841
import org.junit.jupiter.api.Test;
3942
import org.springframework.beans.factory.annotation.Autowired;
@@ -196,6 +199,27 @@ public void listStaging() {
196199
.verify(Duration.ofMinutes(5));
197200
}
198201

202+
@Test
203+
public void listWithPagination() {
204+
this.securityGroup
205+
.map(
206+
securityGroup ->
207+
PaginationUtils.requestClientV3Resources(
208+
page ->
209+
cloudFoundryClient
210+
.securityGroupsV3()
211+
.list(
212+
ListSecurityGroupsRequest.builder()
213+
.page(page)
214+
.perPage(1)
215+
.names(Collections.singletonList(securityGroup.getName()))
216+
.build())))
217+
.as(StepVerifier::create)
218+
.expectNextCount(1)
219+
.expectComplete()
220+
.verify(Duration.ofMinutes(5));
221+
}
222+
199223
@Test
200224
public void bindStagingSecurityGroup() {
201225
Mono.zip(this.securityGroup, this.spaceId)

0 commit comments

Comments
 (0)