feat: Cleanup the recentLogs endpoint

Author: ZPascal

cloudfoundry-client-reactor/src/main/java/org/cloudfoundry/reactor/logcache/v1/ReactorLogCacheEndpoints.java

@@ -48,8 +48,4 @@ Mono<MetaResponse> meta(MetaRequest request) {
     Mono<ReadResponse> read(ReadRequest request) {
         return get(request, ReadResponse.class, "read", request.getSourceId()).checkpoint();
     }
-
-    Mono<ReadResponse> recentLogs(ReadRequest request) {
-        return read(request);
-    }
 }

cloudfoundry-client-reactor/src/main/java/org/cloudfoundry/reactor/logcache/v1/_ReactorLogCacheClient.java

@@ -53,11 +53,6 @@ public Mono<ReadResponse> read(ReadRequest request) {
         return getReactorLogCacheEndpoints().read(request);
     }
 
-    @Override
-    public Mono<ReadResponse> recentLogs(ReadRequest request) {
-        return getReactorLogCacheEndpoints().recentLogs(request);
-    }
-
     /**
      * The connection context
      */

cloudfoundry-client/src/main/java/org/cloudfoundry/doppler/DopplerClient.java

@@ -42,13 +42,13 @@ public interface DopplerClient {
     /**
      * Makes the <a href="https://github.com/cloudfoundry/loggregator/tree/develop/src/trafficcontroller#endpoints">Recent Logs</a> request
      *
-     * @deprecated Use {@link org.cloudfoundry.logcache.v1.LogCacheClient#recentLogs(org.cloudfoundry.logcache.v1.ReadRequest)} instead.
+     * @deprecated Use {@link org.cloudfoundry.logcache.v1.LogCacheClient#read(org.cloudfoundry.logcache.v1.ReadRequest)} instead.
      * Only works with {@code Loggregator < 107.0}, shipped in {@code CFD < 24.3} and {@code TAS < 4.0}.
      * @param request the Recent Logs request
      * @return a flux of events from the recent logs
      * @see <a href="https://github.com/cloudfoundry/loggregator">Loggregator</a>
      * @see <a href="https://github.com/cloudfoundry/log-cache">Log Cache</a>
-     * @see org.cloudfoundry.logcache.v1.LogCacheClient#recentLogs(org.cloudfoundry.logcache.v1.ReadRequest)
+     * @see org.cloudfoundry.logcache.v1.LogCacheClient#read(org.cloudfoundry.logcache.v1.ReadRequest)
      */
     @Deprecated
     Flux<Envelope> recentLogs(RecentLogsRequest request);

cloudfoundry-client/src/main/java/org/cloudfoundry/logcache/v1/LogCacheClient.java

@@ -46,12 +46,4 @@ public interface LogCacheClient {
      * @return the read response
      */
     Mono<ReadResponse> read(ReadRequest request);
-
-    /**
-     * Makes the Log Cache RecentLogs /api/v1/read request
-     *
-     * @param request the Recent Logs request
-     * @return the events from the recent logs
-     */
-    Mono<ReadResponse> recentLogs(ReadRequest request);
 }

cloudfoundry-operations/src/main/java/org/cloudfoundry/operations/applications/DefaultApplications.java

@@ -2545,7 +2545,7 @@ private static Mono<EnvelopeBatch> requestLogsRecentLogCache(
             Mono<LogCacheClient> logCacheClient, ReadRequest readRequest) {
         return logCacheClient.flatMap(
                 client ->
-                        client.recentLogs(readRequest)
+                        client.read(readRequest)
                                 .flatMap(response -> Mono.justOrEmpty(response.getEnvelopes())));
     }
 

cloudfoundry-operations/src/test/java/org/cloudfoundry/operations/applications/DefaultApplicationsTest.java

@@ -5361,7 +5361,7 @@ private static void requestLogsRecent(DopplerClient dopplerClient, String applic
 
     private static void requestLogsRecentLogCache(
             LogCacheClient logCacheClient, String sourceId, String payload) {
-        when(logCacheClient.recentLogs(ReadRequest.builder().sourceId(sourceId).build()))
+        when(logCacheClient.read(ReadRequest.builder().sourceId(sourceId).build()))
                 .thenReturn(
                         Mono.just(
                                 fill(ReadResponse.builder())