Skip to content

DefaultDomains: deprecate and point to client v3 api #1324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Kehrlann wants to merge 2 commits into from
Closed

DefaultDomains: deprecate and point to client v3 api #1324

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c3f770
DefaultDomains: constructor takes XyzClient, not Mono<XyzClient>
Kehrlann Dec 8, 2025
c87f56c
Deprecate org.cloudfoundry.operations.domains.Domains
Kehrlann Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Deprecate org.cloudfoundry.operations.domains.Domains
  • Loading branch information
@Kehrlann
Kehrlann committed Dec 11, 2025
commit c87f56cd7c2b18fef11bcb9a6dfe7f5d998d90fc
3 changes: 3 additions & 0 deletions ...dfoundry-operations/src/main/java/org/cloudfoundry/operations/CloudFoundryOperations.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

package org.cloudfoundry.operations;

import org.cloudfoundry.client.CloudFoundryClient;
import org.cloudfoundry.operations.advanced.Advanced;
import org.cloudfoundry.operations.applications.Applications;
import org.cloudfoundry.operations.buildpacks.Buildpacks;
Expand Down Expand Up @@ -66,7 +67,9 @@ public interface CloudFoundryOperations {
* Main entry point to the Cloud Foundry Domains Operations API
*
* @return the Cloud Foundry Domains Operations API
* @deprecated use {@link CloudFoundryClient#domainsV3()} instead.
*/
@Deprecated
Domains domains();

/**
Expand Down
6 changes: 6 additions & 0 deletions ...dfoundry-operations/src/main/java/org/cloudfoundry/operations/domains/DefaultDomains.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ public DefaultDomains(
this.routingClient = routingClient.block();
}

@Deprecated
@Override
public Mono<Void> create(CreateDomainRequest request) {
return getOrganizationId(request.getOrganization())
Expand All @@ -73,6 +74,7 @@ public Mono<Void> create(CreateDomainRequest request) {
.checkpoint();
}

@Deprecated
@Override
public Mono<Void> createShared(CreateSharedDomainRequest request) {
if (request.getRouterGroup() == null) {
Expand All @@ -91,6 +93,7 @@ public Mono<Void> createShared(CreateSharedDomainRequest request) {
}
}

@Deprecated
@Override
public Flux<Domain> list() {
return requestListPrivateDomains()
Expand All @@ -100,6 +103,7 @@ public Flux<Domain> list() {
.checkpoint();
}

@Deprecated
@Override
public Flux<RouterGroup> listRouterGroups() {
return requestListRouterGroups(routingClient)
Expand All @@ -109,6 +113,7 @@ public Flux<RouterGroup> listRouterGroups() {
.checkpoint();
}

@Deprecated
@Override
public Mono<Void> share(ShareDomainRequest request) {
return Mono.zip(
Expand All @@ -120,6 +125,7 @@ public Mono<Void> share(ShareDomainRequest request) {
.checkpoint();
}

@Deprecated
@Override
public Mono<Void> unshare(UnshareDomainRequest request) {
return Mono.zip(
Expand Down
8 changes: 8 additions & 0 deletions cloudfoundry-operations/src/main/java/org/cloudfoundry/operations/domains/Domains.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,15 +29,19 @@ public interface Domains {
*
* @param request The Create Domain request
* @return a completion indicator
* @deprecated use {@link #createV3} instead
*/
@Deprecated
Mono<Void> create(CreateDomainRequest request);

/**
* Create a new shared domain
*
* @param request the Create Shared Domain request
* @return a completion indicator
* @deprecated use {@link #createV3} instead
*/
@Deprecated
Mono<Void> createShared(CreateSharedDomainRequest request);

/**
Expand All @@ -59,14 +63,18 @@ public interface Domains {
*
* @param request The Share Domain request
* @return a completion indicator
* @deprecated use {@link #update} instead.
*/
@Deprecated
Mono<Void> share(ShareDomainRequest request);

/**
* Unshare a private domain
*
* @param request The Unshare Domain request
* @return a completion indicator
* @deprecated use {@link #update} instead.
*/
@Deprecated
Mono<Void> unshare(UnshareDomainRequest request);
}