Skip to content

Commit 5fd3ebc

Browse files
mauricebrinkmannsethboyles
mauricebrinkmann
authored and
sethboyles
committed
completed refactoring for dest port
1 parent 870f14c commit 5fd3ebc

File tree

10 files changed

+117
-55
lines changed

10 files changed

+117
-55
lines changed

‎.gitignore‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,3 +70,4 @@ integration/assets/test_plugin/test_plugin
7070
.vscode
7171
.secrets
7272
.vars
73+
.patch

‎actor/v7action/route.go‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -284,7 +284,9 @@ func (actor Actor) GetRouteSummaries(routes []resources.Route) ([]RouteSummary,
284284
for _, destination := range route.Destinations {
285285
appNames = append(appNames, appNamesByGUID[destination.App.GUID])
286286
protocolSet[destination.Protocol] = true
287-
portSet[destination.Port] = true
287+
if destination.Port > 0 {
288+
portSet[destination.Port] = true
289+
}
288290
}
289291

290292
var appProtocols []string

‎actor/v7action/route_test.go‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1581,19 +1581,21 @@ var _ = Describe("Route Actions", func() {
15811581
routeGUID string
15821582
appGUID string
15831583
destinationProtocol string
1584+
destinationPort int
15841585

15851586
executeErr error
15861587
warnings Warnings
15871588
)
15881589

15891590
JustBeforeEach(func() {
1590-
warnings, executeErr = actor.MapRoute(routeGUID, appGUID, destinationProtocol)
1591+
warnings, executeErr = actor.MapRoute(routeGUID, appGUID, destinationProtocol, destinationPort)
15911592
})
15921593

15931594
BeforeEach(func() {
15941595
routeGUID = "route-guid"
15951596
appGUID = "app-guid"
15961597
destinationProtocol = "http2"
1598+
destinationPort = 8080
15971599
})
15981600

15991601
When("the cloud controller client errors", func() {
@@ -1613,10 +1615,11 @@ var _ = Describe("Route Actions", func() {
16131615
})
16141616

16151617
It("calls the cloud controller client with the right arguments", func() {
1616-
actualRouteGUID, actualAppGUID, actualDestinationProtocol := fakeCloudControllerClient.MapRouteArgsForCall(0)
1618+
actualRouteGUID, actualAppGUID, actualDestinationProtocol, actualDestinationPort := fakeCloudControllerClient.MapRouteArgsForCall(0)
16171619
Expect(actualRouteGUID).To(Equal("route-guid"))
16181620
Expect(actualAppGUID).To(Equal("app-guid"))
16191621
Expect(actualDestinationProtocol).To(Equal("http2"))
1622+
Expect(actualDestinationPort).To(Equal(8080))
16201623
})
16211624

16221625
It("returns the error and warnings", func() {

‎actor/v7action/v7actionfakes/fake_cloud_controller_client.go‎

Lines changed: 10 additions & 8 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎actor/v7pushaction/v7_actor.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ type V7Actor interface {
2525
GetDomain(domainGUID string) (resources.Domain, v7action.Warnings, error)
2626
GetRouteByAttributes(domain resources.Domain, hostname, path string, port int) (resources.Route, v7action.Warnings, error)
2727
GetRouteDestinationByAppGUID(route resources.Route, appGUID string) (resources.RouteDestination, error)
28-
MapRoute(routeGUID string, appGUID string, destinationProtocol string) (v7action.Warnings, error)
28+
MapRoute(routeGUID string, appGUID string, destinationProtocol string, destinationPort int) (v7action.Warnings, error)
2929
PollBuild(buildGUID string, appName string) (resources.Droplet, v7action.Warnings, error)
3030
PollPackage(pkg resources.Package) (resources.Package, v7action.Warnings, error)
3131
PollStart(app resources.Application, noWait bool, handleProcessStats func(string)) (v7action.Warnings, error)

‎actor/v7pushaction/v7pushactionfakes/fake_v7actor.go‎

Lines changed: 10 additions & 8 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎api/cloudcontroller/ccv3/route.go‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ func (client Client) UpdateRoute(routeGUID string, options map[string]*string) (
100100

101101
}
102102

103-
func (client Client) MapRoute(routeGUID string, appGUID string, destinationProtocol string) (Warnings, error) {
103+
func (client Client) MapRoute(routeGUID string, appGUID string, destinationProtocol string, destinationPort int) (Warnings, error) {
104104
type destinationProcess struct {
105105
ProcessType string `json:"process_type"`
106106
}
@@ -112,6 +112,7 @@ func (client Client) MapRoute(routeGUID string, appGUID string, destinationProto
112112
type destination struct {
113113
App destinationApp `json:"app"`
114114
Protocol string `json:"protocol,omitempty"`
115+
Port int `json:"port,omitempty"`
115116
}
116117

117118
type body struct {
@@ -128,6 +129,9 @@ func (client Client) MapRoute(routeGUID string, appGUID string, destinationProto
128129
if destinationProtocol != "" {
129130
requestBody.Destinations[0].Protocol = destinationProtocol
130131
}
132+
if destinationPort != 0 {
133+
requestBody.Destinations[0].Port = destinationPort
134+
}
131135

132136
_, warnings, err := client.MakeRequest(RequestParams{
133137
RequestName: internal.MapRouteRequest,

‎api/cloudcontroller/ccv3/route_test.go‎

Lines changed: 49 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -577,6 +577,7 @@ var _ = Describe("Route", func() {
577577
routeGUID = "route-guid"
578578
appGUID = "app-guid"
579579
destinationProtocol string
580+
destinationPort int
580581
expectedBody string
581582
warnings Warnings
582583
executeErr error
@@ -591,24 +592,26 @@ var _ = Describe("Route", func() {
591592
RespondWith(http.StatusOK, response, http.Header{"X-Cf-Warnings": {"warning-1"}}),
592593
),
593594
)
594-
warnings, executeErr = client.MapRoute(routeGUID, appGUID, destinationProtocol)
595+
warnings, executeErr = client.MapRoute(routeGUID, appGUID, destinationProtocol, destinationPort)
595596
})
596597

597598
When("the request is successful", func() {
598599
BeforeEach(func() {
599600
destinationProtocol = "http2"
601+
destinationPort = 8080
600602
expectedBody = fmt.Sprintf(`
601-
{
602-
"destinations": [
603-
{
604-
"app": {
605-
"guid": "%s"
606-
},
607-
"protocol": "%s"
608-
}
609-
]
610-
}
611-
`, appGUID, destinationProtocol)
603+
{
604+
"destinations": [
605+
{
606+
"app": {
607+
"guid": "%s"
608+
},
609+
"protocol": "%s",
610+
"port": %d
611+
}
612+
]
613+
}
614+
`, appGUID, destinationProtocol, destinationPort)
612615
})
613616

614617
It("returns the warnings and no error", func() {
@@ -620,24 +623,48 @@ var _ = Describe("Route", func() {
620623
Context("when destination protocol is not provided", func() {
621624
BeforeEach(func() {
622625
destinationProtocol = ""
626+
destinationPort = 0
623627
expectedBody = fmt.Sprintf(`
624-
{
625-
"destinations": [
626-
{
627-
"app": {
628-
"guid": "%s"
629-
}
630-
}
631-
]
632-
}
633-
`, appGUID)
628+
{
629+
"destinations": [
630+
{
631+
"app": {
632+
"guid": "%s"
633+
}
634+
}
635+
]
636+
}
637+
`, appGUID)
634638
})
635639

636640
It("does not include it in the request", func() {
637641
Expect(executeErr).ToNot(HaveOccurred())
638642
})
639643
})
640644

645+
Context("when destination port is provided without protocol", func() {
646+
BeforeEach(func() {
647+
destinationProtocol = ""
648+
destinationPort = 9090
649+
expectedBody = fmt.Sprintf(`
650+
{
651+
"destinations": [
652+
{
653+
"app": {
654+
"guid": "%s"
655+
},
656+
"port": %d
657+
}
658+
]
659+
}
660+
`, appGUID, destinationPort)
661+
})
662+
663+
It("includes the port in the request", func() {
664+
Expect(executeErr).ToNot(HaveOccurred())
665+
})
666+
})
667+
641668
When("the cloud controller returns errors and warnings", func() {
642669
BeforeEach(func() {
643670
response := `{

‎command/v7/map_route_command_test.go‎

Lines changed: 23 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -448,10 +448,11 @@ var _ = Describe("map-route Command", func() {
448448
Expect(actualPort).To(Equal(cmd.Port))
449449

450450
Expect(fakeActor.MapRouteCallCount()).To(Equal(1))
451-
actualRouteGUID, actualAppGUID, actualAppProtocol := fakeActor.MapRouteArgsForCall(0)
451+
actualRouteGUID, actualAppGUID, actualAppProtocol, actualAppPort := fakeActor.MapRouteArgsForCall(0)
452452
Expect(actualRouteGUID).To(Equal("route-guid"))
453453
Expect(actualAppGUID).To(Equal("app-guid"))
454454
Expect(actualAppProtocol).To(Equal("http2"))
455+
Expect(actualAppPort).To(Equal(0))
455456
})
456457
})
457458

@@ -487,10 +488,11 @@ var _ = Describe("map-route Command", func() {
487488
Expect(actualPort).To(Equal(cmd.Port))
488489

489490
Expect(fakeActor.MapRouteCallCount()).To(Equal(1))
490-
actualRouteGUID, actualAppGUID, actualAppProtocol := fakeActor.MapRouteArgsForCall(0)
491+
actualRouteGUID, actualAppGUID, actualAppProtocol, actualAppPort := fakeActor.MapRouteArgsForCall(0)
491492
Expect(actualRouteGUID).To(Equal("route-guid"))
492493
Expect(actualAppGUID).To(Equal("app-guid"))
493494
Expect(actualAppProtocol).To(Equal("http2"))
495+
Expect(actualAppPort).To(Equal(0))
494496
})
495497
})
496498
})
@@ -631,10 +633,11 @@ var _ = Describe("map-route Command", func() {
631633
Expect(actualPort).To(Equal(cmd.Port))
632634

633635
Expect(fakeActor.MapRouteCallCount()).To(Equal(1))
634-
actualRouteGUID, actualAppGUID, actualAppProtocol := fakeActor.MapRouteArgsForCall(0)
636+
actualRouteGUID, actualAppGUID, actualAppProtocol, actualAppPort := fakeActor.MapRouteArgsForCall(0)
635637
Expect(actualRouteGUID).To(Equal("route-guid"))
636638
Expect(actualAppGUID).To(Equal("app-guid"))
637639
Expect(actualAppProtocol).To(Equal("http2"))
640+
Expect(actualAppPort).To(Equal(0))
638641
})
639642
})
640643

@@ -670,10 +673,26 @@ var _ = Describe("map-route Command", func() {
670673
Expect(actualPort).To(Equal(cmd.Port))
671674

672675
Expect(fakeActor.MapRouteCallCount()).To(Equal(1))
673-
actualRouteGUID, actualAppGUID, actualAppProtocol := fakeActor.MapRouteArgsForCall(0)
676+
actualRouteGUID, actualAppGUID, actualAppProtocol, actualAppPort := fakeActor.MapRouteArgsForCall(0)
674677
Expect(actualRouteGUID).To(Equal("route-guid"))
675678
Expect(actualAppGUID).To(Equal("app-guid"))
676679
Expect(actualAppProtocol).To(Equal("http2"))
680+
Expect(actualAppPort).To(Equal(0))
681+
})
682+
})
683+
684+
Context("when an app port is provided", func() {
685+
BeforeEach(func() {
686+
cmd.AppPort = 9292
687+
})
688+
689+
It("passes the port to the actor", func() {
690+
Expect(fakeActor.MapRouteCallCount()).To(Equal(1))
691+
actualRouteGUID, actualAppGUID, actualAppProtocol, actualAppPort := fakeActor.MapRouteArgsForCall(0)
692+
Expect(actualRouteGUID).To(Equal("route-guid"))
693+
Expect(actualAppGUID).To(Equal("app-guid"))
694+
Expect(actualAppProtocol).To(Equal("http2"))
695+
Expect(actualAppPort).To(Equal(9292))
677696
})
678697
})
679698
})

0 commit comments

Comments
 (0)