Show reason field for non-active stack states and fix UpdateStack interface

- Display reason: whenever stack state is non-ACTIVE, even if reason is empty
- Update CloudControllerClient and Actor interfaces for 3-arg UpdateStack
- Regenerate fakes for updated interfaces
- Fix duplicate Execute call in update-stack reason test

Co-authored-by: Cursor <cursoragent@cursor.com>

Author: simonjjones

actor/v7action/cloud_controller_client.go

@@ -138,7 +138,7 @@ type CloudControllerClient interface {
 	GetAppFeature(appGUID string, featureName string) (resources.ApplicationFeature, ccv3.Warnings, error)
 	GetStacks(query ...ccv3.Query) ([]resources.Stack, ccv3.Warnings, error)
 	GetStagingSecurityGroups(spaceGUID string, queries ...ccv3.Query) ([]resources.SecurityGroup, ccv3.Warnings, error)
-	UpdateStack(stackGUID string, state string) (resources.Stack, ccv3.Warnings, error)
+	UpdateStack(stackGUID string, state string, reason string) (resources.Stack, ccv3.Warnings, error)
 	GetTask(guid string) (resources.Task, ccv3.Warnings, error)
 	GetUser(userGUID string) (resources.User, ccv3.Warnings, error)
 	GetUsers(query ...ccv3.Query) ([]resources.User, ccv3.Warnings, error)

actor/v7action/stack_test.go

@@ -238,6 +238,7 @@ var _ = Describe("Stack", func() {
 		var (
 			stackGUID  string
 			state      string
+			reason     string
 			stack      resources.Stack
 			warnings   Warnings
 			executeErr error
@@ -246,10 +247,11 @@ var _ = Describe("Stack", func() {
 		BeforeEach(func() {
 			stackGUID = "some-stack-guid"
 			state = "DEPRECATED"
+			reason = ""
 		})
 
 		JustBeforeEach(func() {
-			stack, warnings, executeErr = actor.UpdateStack(stackGUID, state)
+			stack, warnings, executeErr = actor.UpdateStack(stackGUID, state, reason)
 		})
 
 		When("the cloud controller request is successful", func() {
@@ -277,9 +279,10 @@ var _ = Describe("Stack", func() {
 				}))
 
 				Expect(fakeCloudControllerClient.UpdateStackCallCount()).To(Equal(1))
-				actualGUID, actualState := fakeCloudControllerClient.UpdateStackArgsForCall(0)
+				actualGUID, actualState, actualReason := fakeCloudControllerClient.UpdateStackArgsForCall(0)
 				Expect(actualGUID).To(Equal(stackGUID))
 				Expect(actualState).To(Equal(state))
+				Expect(actualReason).To(Equal(reason))
 			})
 		})
 

actor/v7action/v7actionfakes/fake_cloud_controller_client.go

@@ -179,7 +179,7 @@ type Actor interface {
 	GetStackByName(stackName string) (resources.Stack, v7action.Warnings, error)
 	GetStackLabels(stackName string) (map[string]types.NullString, v7action.Warnings, error)
 	GetStacks(string) ([]resources.Stack, v7action.Warnings, error)
-	UpdateStack(stackGUID string, state string) (resources.Stack, v7action.Warnings, error)
+	UpdateStack(stackGUID string, state string, reason string) (resources.Stack, v7action.Warnings, error)
 	GetStreamingLogsForApplicationByNameAndSpace(appName string, spaceGUID string, client sharedaction.LogCacheClient) (<-chan sharedaction.LogMessage, <-chan error, context.CancelFunc, v7action.Warnings, error)
 	GetTaskBySequenceIDAndApplication(sequenceID int, appGUID string) (resources.Task, v7action.Warnings, error)
 	GetUAAAPIVersion() (string, error)

command/v7/actor.go

@@ -70,8 +70,8 @@ func (cmd *StackCommand) displayStackInfo() error {
 	if stack.State != "" {
 		displayTable = append(displayTable, []string{cmd.UI.TranslateText("state:"), stack.State})
 
-		// Add reason only if state is not ACTIVE and reason is present
-		if stack.State != resources.StackStateActive && stack.StateReason != "" {
+		// Add reason whenever state is not ACTIVE
+		if stack.State != resources.StackStateActive {
 			displayTable = append(displayTable, []string{cmd.UI.TranslateText("reason:"), stack.StateReason})
 		}
 	}

command/v7/stack_command.go

@@ -196,29 +196,29 @@ var _ = Describe("Stack Command", func() {
 				})
 			})
 
-			Context("When the state is not ACTIVE but has no reason", func() {
-				BeforeEach(func() {
-					stack := resources.Stack{
-						Name:        "some-stack-name",
-						GUID:        "some-stack-guid",
-						Description: "some-stack-desc",
-						State:       "RESTRICTED",
-					}
-					fakeActor.GetStackByNameReturns(stack, v7action.Warnings{}, nil)
-				})
+		Context("When the state is not ACTIVE but has no reason", func() {
+			BeforeEach(func() {
+				stack := resources.Stack{
+					Name:        "some-stack-name",
+					GUID:        "some-stack-guid",
+					Description: "some-stack-desc",
+					State:       "RESTRICTED",
+				}
+				fakeActor.GetStackByNameReturns(stack, v7action.Warnings{}, nil)
+			})
 
-				It("Displays the stack information with state but no reason", func() {
-					Expect(executeErr).ToNot(HaveOccurred())
-					Expect(fakeActor.GetStackByNameArgsForCall(0)).To(Equal("some-stack-name"))
-					Expect(fakeActor.GetStackByNameCallCount()).To(Equal(1))
+			It("Displays the stack information with state and empty reason", func() {
+				Expect(executeErr).ToNot(HaveOccurred())
+				Expect(fakeActor.GetStackByNameArgsForCall(0)).To(Equal("some-stack-name"))
+				Expect(fakeActor.GetStackByNameCallCount()).To(Equal(1))
 
-					Expect(testUI.Out).To(Say("name:\\s+some-stack-name"))
-					Expect(testUI.Out).To(Say("description:\\s+some-stack-desc"))
-					Expect(testUI.Out).To(Say("state:\\s+RESTRICTED"))
-					Expect(testUI.Out).NotTo(Say("reason:"))
-				})
+				Expect(testUI.Out).To(Say("name:\\s+some-stack-name"))
+				Expect(testUI.Out).To(Say("description:\\s+some-stack-desc"))
+				Expect(testUI.Out).To(Say("state:\\s+RESTRICTED"))
+				Expect(testUI.Out).To(Say("reason:"))
 			})
 		})
+		})
 
 		When("The Stack does not Exist", func() {
 			expectedError := actionerror.StackNotFoundError{Name: "some-stack-name"}

command/v7/stack_command_test.go

@@ -73,8 +73,8 @@ func (cmd UpdateStackCommand) Execute(args []string) error {
 		{cmd.UI.TranslateText("state:"), updatedStack.State},
 	}
 
-	// Add reason if it's present
-	if updatedStack.StateReason != "" {
+	// Add reason whenever state is not ACTIVE
+	if updatedStack.State != resources.StackStateActive {
 		displayTable = append(displayTable, []string{cmd.UI.TranslateText("reason:"), updatedStack.StateReason})
 	}
 

command/v7/update_stack_command.go

@@ -210,8 +210,6 @@ var _ = Describe("update-stack Command", func() {
 		})
 
 		It("passes the reason to the actor and displays it", func() {
-			executeErr = cmd.Execute(args)
-
 			Expect(executeErr).ToNot(HaveOccurred())
 
 			Expect(fakeActor.UpdateStackCallCount()).To(Equal(1))