Command "services": Eliminate duplicate app names (#3663)

* in case of multiple service bindings per (service instance guid, app guid), eliminate duplicate app names in the "bound apps" section

Author: jochenehret

actor/v7action/service_instance_list.go

@@ -121,10 +121,20 @@ func buildPlanDetailsLookup(included ccv3.IncludedResources) map[string]planDeta
 }
 
 func buildBoundAppsLookup(bindings []resources.ServiceCredentialBinding, spaceGUID string) map[string][]string {
+	type bindingKey struct {
+		appGUID             string
+		serviceInstanceGUID string
+	}
+	seenBindingKeys := make(map[bindingKey]struct{})
 	appsBoundLookup := make(map[string][]string)
 	for _, binding := range bindings {
 		if binding.Type == resources.AppBinding && binding.AppSpaceGUID == spaceGUID {
-			appsBoundLookup[binding.ServiceInstanceGUID] = append(appsBoundLookup[binding.ServiceInstanceGUID], binding.AppName)
+			bk := bindingKey{appGUID: binding.AppGUID, serviceInstanceGUID: binding.ServiceInstanceGUID}
+			// Prevent duplicate app names for the same service instance in case of duplicate bindings
+			if _, exists := seenBindingKeys[bk]; !exists {
+				appsBoundLookup[binding.ServiceInstanceGUID] = append(appsBoundLookup[binding.ServiceInstanceGUID], binding.AppName)
+				seenBindingKeys[bk] = struct{}{}
+			}
 		}
 	}
 	return appsBoundLookup

actor/v7action/service_instance_list_test.go

@@ -142,6 +142,8 @@ var _ = Describe("Service Instance List Action", func() {
 		)
 		fakeCloudControllerClient.GetServiceCredentialBindingsReturns(
 			[]resources.ServiceCredentialBinding{
+				{Type: "app", ServiceInstanceGUID: "fake-guid-1", AppGUID: "app-1", AppName: "great-app-1", AppSpaceGUID: spaceGUID},
+				// Duplicate binding for (app-1, fake-guid-1) pair to ensure app names are not duplicated
 				{Type: "app", ServiceInstanceGUID: "fake-guid-1", AppGUID: "app-1", AppName: "great-app-1", AppSpaceGUID: spaceGUID},
 				{Type: "app", ServiceInstanceGUID: "fake-guid-1", AppGUID: "app-2", AppName: "great-app-2", AppSpaceGUID: spaceGUID},
 				{Type: "app", ServiceInstanceGUID: "fake-guid-2", AppGUID: "app-3", AppName: "great-app-3", AppSpaceGUID: spaceGUID},