Skip to content

Commit 9da44fe

Browse files
anujc25gururajsh
andauthored
Fix improper Eventually usage in servicebrokerstub (#3648)
The ensureAppIsDeployed helper was calling appResponds() immediately and passing the result (a boolean) to Eventually. This prevented Gomega from polling the function, causing failures if the app wasn't ready instantly. This change passes the function reference appResponds to Eventually so it can be polled correctly, and adds a 1-minute timeout to allow for slower environments. Co-authored-by: Shwetha Gururaj <shwetha.gururaj@broadcom.com>
1 parent c4cd705 commit 9da44fe

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

integration/helpers/servicebrokerstub/app_deploy.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ func initialize() {
3737
func ensureAppIsDeployed() {
3838
if !appResponds() {
3939
ensureAppIsPushed()
40-
Eventually(appResponds()).Should(BeTrue())
40+
Eventually(appResponds, time.Minute).Should(BeTrue())
4141
}
4242
}
4343

0 commit comments

Comments
 (0)