Skip to content

Commit b583e2d

Browse files
committed
Remove default order_by query in GetBuildpacks
- This will allow capi to update the default order independently of the cli in the future Signed-off-by: Tom Kennedy <tom.kennedy@broadcom.com>
1 parent 7edc0d7 commit b583e2d

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

actor/v7action/buildpack.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ type Downloader interface {
2222
}
2323

2424
func (actor Actor) GetBuildpacks(labelSelector string, lifecycle string) ([]resources.Buildpack, Warnings, error) {
25-
queries := []ccv3.Query{ccv3.Query{Key: ccv3.OrderBy, Values: []string{ccv3.PositionOrder}}}
25+
queries := []ccv3.Query{}
2626
if labelSelector != "" {
2727
queries = append(queries, ccv3.Query{Key: ccv3.LabelSelectorFilter, Values: []string{labelSelector}})
2828
}

actor/v7action/buildpack_test.go

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -214,9 +214,8 @@ var _ = Describe("Buildpack", func() {
214214
labelSelector = ""
215215
lifecycle = ""
216216
})
217-
It("only passes through a OrderBy query to the CloudControllerClient", func() {
218-
positionQuery := ccv3.Query{Key: ccv3.OrderBy, Values: []string{ccv3.PositionOrder}}
219-
Expect(fakeCloudControllerClient.GetBuildpacksArgsForCall(0)).To(ConsistOf(positionQuery))
217+
It("does not pass a query to the CloudControllerClient", func() {
218+
Expect(fakeCloudControllerClient.GetBuildpacksArgsForCall(0)).To(BeEmpty())
220219
})
221220
})
222221

0 commit comments

Comments
 (0)