Remove Per-Route Options from the Apps and the App commands [main] (#3408)

* cf apps output too versbose

* cf apps output app summary

* One additional unit test

* Refactor

* Try to fix integration tests

* New unit test

Author: Dariquest

command/v7/apps_command.go

@@ -79,7 +79,7 @@ func (cmd AppsCommand) Execute(args []string) error {
 func getURLs(routes []resources.Route) string {
 	var routeURLs []string
 	for _, route := range routes {
-		routeURLs = append(routeURLs, route.URL+route.FormattedOptions())
+		routeURLs = append(routeURLs, route.URL)
 	}
 
 	return strings.Join(routeURLs, ", ")

command/v7/apps_command_test.go

@@ -239,7 +239,7 @@ var _ = Describe("apps Command", func() {
 				Expect(testUI.Out).To(Say(`Getting apps in org some-org / space some-space as steve\.\.\.`))
 
 				Expect(testUI.Out).To(Say(`name\s+requested state\s+processes\s+routes`))
-				Expect(testUI.Out).To(Say(`some-app-1\s+started\s+web:2/2, console:0/0, worker:0/1\s+some-app-1.some-other-domain {loadbalancing=least-connection}, some-app-1.some-domain`))
+				Expect(testUI.Out).To(Say(`some-app-1\s+started\s+web:2/2, console:0/0, worker:0/1\s+some-app-1.some-other-domain, some-app-1.some-domain`))
 
 				Expect(testUI.Err).To(Say("warning-1"))
 				Expect(testUI.Err).To(Say("warning-2"))
@@ -346,5 +346,4 @@ var _ = Describe("apps Command", func() {
 			Expect(omitStats).To(Equal(true))
 		})
 	})
-
 })

command/v7/shared/app_summary_displayer.go

@@ -59,7 +59,7 @@ func (display AppSummaryDisplayer) AppDisplay(summary v7action.DetailedApplicati
 func routeSummary(rs []resources.Route) string {
 	formattedRoutes := []string{}
 	for _, route := range rs {
-		formattedRoutes = append(formattedRoutes, route.URL+route.FormattedOptions())
+		formattedRoutes = append(formattedRoutes, route.URL)
 	}
 	return strings.Join(formattedRoutes, ", ")
 }

command/v7/shared/app_summary_displayer_test.go

@@ -616,8 +616,8 @@ var _ = Describe("app summary displayer", func() {
 				}
 			})
 
-			It("displays routes", func() {
-				Expect(testUI.Out).To(Say(`routes:\s+%s, %s`, "route1.example.com {loadbalancing=least-connection}", "route2.example.com"))
+			It("displays routes without their options", func() {
+				Expect(testUI.Out).To(Say(`routes:\s+%s, %s`, "route1.example.com", "route2.example.com"))
 			})
 		})