Skip to content

Commit bfd7e4c

Browse files
authored
Merge branch 'main' into it-test-improvements-main
2 parents 24e7add + c4cd705 commit bfd7e4c

4 files changed

Lines changed: 14 additions & 10 deletions

File tree

command/flag/app_type.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,5 +5,5 @@ import flags "github.com/jessevdk/go-flags"
55
type AppType string
66

77
func (AppType) Complete(prefix string) []flags.Completion {
8-
return completions([]string{"buildpack", "docker"}, prefix, false)
8+
return completions([]string{"buildpack", "docker", "cnb"}, prefix, false)
99
}

command/flag/app_type_test.go

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,14 +19,16 @@ var _ = Describe("AppType", func() {
1919

2020
Entry("completes to 'buildpack' when passed 'b'", "b",
2121
[]flags.Completion{{Item: "buildpack"}}),
22+
Entry("completes to 'cnb' when passed 'c'", "c",
23+
[]flags.Completion{{Item: "cnb"}}),
2224
Entry("completes to 'docker' when passed 'd'", "d",
2325
[]flags.Completion{{Item: "docker"}}),
2426
Entry("completes to 'buildpack' when passed 'bU'", "bU",
2527
[]flags.Completion{{Item: "buildpack"}}),
2628
Entry("completes to 'docker' when passed 'Do'", "Do",
2729
[]flags.Completion{{Item: "docker"}}),
28-
Entry("returns 'buildpack' and 'docker' when passed nothing", "",
29-
[]flags.Completion{{Item: "buildpack"}, {Item: "docker"}}),
30+
Entry("returns 'buildpack', 'cnb', and 'docker' when passed nothing", "",
31+
[]flags.Completion{{Item: "buildpack"}, {Item: "docker"}, {Item: "cnb"}}),
3032
Entry("completes to nothing when passed 'wut'", "wut",
3133
[]flags.Completion{}),
3234
)

command/flag/space_role.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ type SpaceRole struct {
1111
}
1212

1313
func (SpaceRole) Complete(prefix string) []flags.Completion {
14-
return completions([]string{"SpaceManager", "SpaceDeveloper", "SpaceAuditor"}, prefix, false)
14+
return completions([]string{"SpaceManager", "SpaceDeveloper", "SpaceAuditor", "SpaceSupporter"}, prefix, false)
1515
}
1616

1717
func (s *SpaceRole) UnmarshalFlag(val string) error {

command/flag/space_role_test.go

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,10 @@ var _ = Describe("SpaceRole", func() {
1616
completions := spaceRole.Complete(prefix)
1717
Expect(completions).To(Equal(matches))
1818
},
19-
Entry("returns 'SpaceManager', 'SpaceDeveloper' and 'SpaceAuditor' when passed 'S'", "S",
20-
[]flags.Completion{{Item: "SpaceManager"}, {Item: "SpaceDeveloper"}, {Item: "SpaceAuditor"}}),
21-
Entry("returns 'SpaceManager', 'SpaceDeveloper' and 'SpaceAuditor' when passed 's'", "s",
22-
[]flags.Completion{{Item: "SpaceManager"}, {Item: "SpaceDeveloper"}, {Item: "SpaceAuditor"}}),
19+
Entry("returns 'SpaceManager', 'SpaceDeveloper', 'SpaceAuditor' and 'SpaceSupporter' when passed 'S'", "S",
20+
[]flags.Completion{{Item: "SpaceManager"}, {Item: "SpaceDeveloper"}, {Item: "SpaceAuditor"}, {Item: "SpaceSupporter"}}),
21+
Entry("returns 'SpaceManager', 'SpaceDeveloper', 'SpaceAuditor' and 'SpaceSupporter' when passed 's'", "s",
22+
[]flags.Completion{{Item: "SpaceManager"}, {Item: "SpaceDeveloper"}, {Item: "SpaceAuditor"}, {Item: "SpaceSupporter"}}),
2323
Entry("completes to 'SpaceAuditor' when passed 'Spacea'", "Spacea",
2424
[]flags.Completion{{Item: "SpaceAuditor"}}),
2525
Entry("completes to 'SpaceDeveloper' when passed 'Spaced'", "Spaced",
@@ -28,8 +28,10 @@ var _ = Describe("SpaceRole", func() {
2828
[]flags.Completion{{Item: "SpaceManager"}}),
2929
Entry("completes to 'SpaceManager' when passed 'spacEM'", "spacEM",
3030
[]flags.Completion{{Item: "SpaceManager"}}),
31-
Entry("returns 'SpaceManager', 'SpaceDeveloper' and 'SpaceAuditor' when passed nothing", "",
32-
[]flags.Completion{{Item: "SpaceManager"}, {Item: "SpaceDeveloper"}, {Item: "SpaceAuditor"}}),
31+
Entry("completes to 'SpaceSupporter' when passed 'Spaces'", "Spaces",
32+
[]flags.Completion{{Item: "SpaceSupporter"}}),
33+
Entry("returns 'SpaceManager', 'SpaceDeveloper', 'SpaceAuditor' and 'SpaceSupporter' when passed nothing", "",
34+
[]flags.Completion{{Item: "SpaceManager"}, {Item: "SpaceDeveloper"}, {Item: "SpaceAuditor"}, {Item: "SpaceSupporter"}}),
3335
Entry("completes to nothing when passed 'wut'", "wut",
3436
[]flags.Completion{}),
3537
)

0 commit comments

Comments
 (0)