Skip to content

Fix null canary object#3435

Merged
Samze merged 1 commit intov8from
fix_canary_object_v8_branch
Mar 4, 2025
Merged

Fix null canary object#3435
Samze merged 1 commit intov8from
fix_canary_object_v8_branch

Conversation

@Samze
Copy link
Copy Markdown
Contributor

@Samze Samze commented Feb 28, 2025

v8 version of #3433

Copy link
Copy Markdown
Contributor

@joaopapereira joaopapereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@gururajsh gururajsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

* Do not send null canary object if no steps have been specified
@Samze Samze force-pushed the fix_canary_object_v8_branch branch from d4c8fa7 to 0d1de6d Compare March 3, 2025 21:39
@Samze Samze merged commit e10661b into v8 Mar 4, 2025
20 checks passed
@Samze Samze deleted the fix_canary_object_v8_branch branch March 4, 2025 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants