Skip to content

Golangci lint latest#3517

Closed
Benjamintf1 wants to merge 3 commits intocloudfoundry:mainfrom
Benjamintf1:golangci-lint-latest
Closed

Golangci lint latest#3517
Benjamintf1 wants to merge 3 commits intocloudfoundry:mainfrom
Benjamintf1:golangci-lint-latest

Conversation

@Benjamintf1
Copy link
Copy Markdown
Member

Thank you for contributing to the CF CLI! Please read the following:

  • Please make sure you have implemented changes in line with the contributing guidelines
  • We're not allowed to accept any PRs without a signed CLA, no matter how small.
    If your contribution falls under a company CLA but your membership is not public, expect delays while we confirm.
  • All new code requires tests to protect against regressions.
  • Contributions must be made against the appropriate branch. See the contributing guidelines
  • Contributions must conform to our style guide. Please reach out to us if you have questions.

Note: Please create separate PR for every branch (main, v8 and v7) as needed.

Description of the Change

We must be able to understand the design of your change from this description.
Keep in mind that the maintainer reviewing this PR may not be familiar with or
have worked with the code here recently, so please walk us through the concepts.

Why Is This PR Valuable?

What benefits will be realized by the code change? What users would want this change? What user need is this change addressing?

Applicable Issues

List any applicable GitHub Issues here

How Urgent Is The Change?

Is the change urgent? If so, explain why it is time-sensitive.

Other Relevant Parties

Who else is affected by the change?

@Benjamintf1
Copy link
Copy Markdown
Member Author

huh strange, my local results are different

@gururajsh
Copy link
Copy Markdown
Member

@Benjamintf1 can we close this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants